Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the broken stories #29530

Closed
Tracked by #29058
nicobytes opened this issue Aug 12, 2024 · 0 comments · Fixed by #29562
Closed
Tracked by #29058

Fix the broken stories #29530

nicobytes opened this issue Aug 12, 2024 · 0 comments · Fixed by #29562
Assignees
@nicobytes
Labels
Merged QA : Not Needed Team : Falcon Type : Task

Comments

@nicobytes
Copy link
Contributor

nicobytes commented Aug 12, 2024 •
edited
Loading

Parent Issue

#29058

Objective

The stories of our components use a StoryBook older version and there are some stories broken and this is important as part of the PrimeNG upgrade to V7 to check that the components work correctly with this migration as a result this task is to fix the broken storybooks and upgrade using the latest StoryBook API.

Fixed Stories

Original Updated
localhost_4400__path=_docs_dotcms-content-palette--docs localhost_4401__path=_docs_dotcms-content-palette--docs
localhost_4400__path=_docs_dotcms-content-palette--docs localhost_4401__path=_docs_dotcms-content-palette--docs
localhost_4400__path=_docs_primeng-form-treeselect--docs localhost_4401__path=_docs_dotcms-content-palette--docs (1)
localhost_4400__path=_docs_primeng-form-treeselect--docs (1) localhost_4401__path=_docs_dotcms-content-palette--docs (2)
localhost_4401__path=_docs_dotcms-device-selector-seo--docs localhost_4400_
localhost_4401__path=_docs_dotcms-device-selector-seo--docs (2) localhost_4400__path=_docs_dotcms-results-seo-tool--docs
@nicobytes nicobytes mentioned this issue Aug 12, 2024
Closed
@nicobytes nicobytes self-assigned this Aug 12, 2024
@nicobytes nicobytes moved this from New to In Progress in dotCMS - Product Planning Aug 12, 2024
@nicobytes nicobytes linked a pull request Aug 12, 2024 that will close this issue
chore: upgrade storybook #29545
Closed
3 tasks
@nicobytes nicobytes removed a link to a pull request Aug 13, 2024
chore: upgrade storybook #29545
Closed
3 tasks
@nicobytes nicobytes linked a pull request Aug 13, 2024 that will close this issue
chore(storybook): upgrade storybook #29562
Merged
3 tasks
@nicobytes nicobytes mentioned this issue Aug 14, 2024
Merged
3 tasks
@nicobytes nicobytes moved this from In Progress to In Review in dotCMS - Product Planning Aug 14, 2024
github-merge-queue bot pushed a commit that referenced this issue Aug 14, 2024
@nicobytes
chore(storybook): upgrade storybook (#29562)
6264e97 
### Parent Issue

#29530

### Objective

The stories of our components use a StoryBook older version and there
are some stories broken and this is important as part of the PrimeNG
upgrade to V17 to check that the components work correctly with this
migration as a result this task is to fix the broken storybooks and
upgrade using the latest StoryBook version.

### Proposed Changes
* Upgrade storybook from v7 to v8
* `Story` was removed in v8 and replace it for `StoryObj`
* Use new format to write stories with strong typing
* Support to signals inputs in stories
* 8 Fixed stories (WIP)

### Checklist
- [x] Tests
- [x] Translations
- [x] Security Implications Contemplated (add notes if applicable)

### Fixed Stories
Original             |  Updated
:-------------------------:|:-------------------------:

![localhost_4400__path=_docs_dotcms-content-palette--docs](https://github.com/user-attachments/assets/76fd5769-bd7b-459d-abdf-29fafeeecb2c)
|
![localhost_4401__path=_docs_dotcms-content-palette--docs](https://github.com/user-attachments/assets/23aade9f-c1ea-49ed-b59d-458dc28f59d4)

![localhost_4400__path=_docs_dotcms-content-palette--docs](https://github.com/user-attachments/assets/15bb931c-5b2a-47e1-aedd-d2a2047a8e43)
|
![localhost_4401__path=_docs_dotcms-content-palette--docs](https://github.com/user-attachments/assets/3097dae1-6fac-4260-8425-5a28909ead4f)

![localhost_4400__path=_docs_primeng-form-treeselect--docs](https://github.com/user-attachments/assets/6cccef59-adfa-4180-91a9-9ef22ca39a84)
| ![localhost_4401__path=_docs_dotcms-content-palette--docs
(1)](https://github.com/user-attachments/assets/352e827a-0c03-4410-bb64-fde683a4477a)
![localhost_4400__path=_docs_primeng-form-treeselect--docs
(1)](https://github.com/user-attachments/assets/0c32516b-2261-438a-838a-05661d2e389a)
| ![localhost_4401__path=_docs_dotcms-content-palette--docs
(2)](https://github.com/user-attachments/assets/864ba32c-41d4-46cc-acd0-6210eac55d24)

![localhost_4401__path=_docs_dotcms-device-selector-seo--docs](https://github.com/user-attachments/assets/73208220-c092-4008-8da8-87c7d059e814)
|
![localhost_4400_](https://github.com/user-attachments/assets/4b316438-e317-420a-a420-519acb2d34b1)
![localhost_4401__path=_docs_dotcms-device-selector-seo--docs
(2)](https://github.com/user-attachments/assets/20f9a891-334f-4962-acb1-7d386dc57d0c)
|
![localhost_4400__path=_docs_dotcms-results-seo-tool--docs](https://github.com/user-attachments/assets/2f8d7503-dfa4-41f9-8730-9ba9713b53f5)
github-merge-queue bot pushed a commit that referenced this issue Aug 15, 2024
@nicobytes
chore(storybook): upgrade storybook (#29562)
b535434 
### Parent Issue

#29530

### Objective

The stories of our components use a StoryBook older version and there
are some stories broken and this is important as part of the PrimeNG
upgrade to V17 to check that the components work correctly with this
migration as a result this task is to fix the broken storybooks and
upgrade using the latest StoryBook version.

### Proposed Changes
* Upgrade storybook from v7 to v8
* `Story` was removed in v8 and replace it for `StoryObj`
* Use new format to write stories with strong typing
* Support to signals inputs in stories
* 8 Fixed stories (WIP)

### Checklist
- [x] Tests
- [x] Translations
- [x] Security Implications Contemplated (add notes if applicable)

### Fixed Stories
Original             |  Updated
:-------------------------:|:-------------------------:

![localhost_4400__path=_docs_dotcms-content-palette--docs](https://github.com/user-attachments/assets/76fd5769-bd7b-459d-abdf-29fafeeecb2c)
|
![localhost_4401__path=_docs_dotcms-content-palette--docs](https://github.com/user-attachments/assets/23aade9f-c1ea-49ed-b59d-458dc28f59d4)

![localhost_4400__path=_docs_dotcms-content-palette--docs](https://github.com/user-attachments/assets/15bb931c-5b2a-47e1-aedd-d2a2047a8e43)
|
![localhost_4401__path=_docs_dotcms-content-palette--docs](https://github.com/user-attachments/assets/3097dae1-6fac-4260-8425-5a28909ead4f)

![localhost_4400__path=_docs_primeng-form-treeselect--docs](https://github.com/user-attachments/assets/6cccef59-adfa-4180-91a9-9ef22ca39a84)
| ![localhost_4401__path=_docs_dotcms-content-palette--docs
(1)](https://github.com/user-attachments/assets/352e827a-0c03-4410-bb64-fde683a4477a)
![localhost_4400__path=_docs_primeng-form-treeselect--docs
(1)](https://github.com/user-attachments/assets/0c32516b-2261-438a-838a-05661d2e389a)
| ![localhost_4401__path=_docs_dotcms-content-palette--docs
(2)](https://github.com/user-attachments/assets/864ba32c-41d4-46cc-acd0-6210eac55d24)

![localhost_4401__path=_docs_dotcms-device-selector-seo--docs](https://github.com/user-attachments/assets/73208220-c092-4008-8da8-87c7d059e814)
|
![localhost_4400_](https://github.com/user-attachments/assets/4b316438-e317-420a-a420-519acb2d34b1)
![localhost_4401__path=_docs_dotcms-device-selector-seo--docs
(2)](https://github.com/user-attachments/assets/20f9a891-334f-4962-acb1-7d386dc57d0c)
|
![localhost_4400__path=_docs_dotcms-results-seo-tool--docs](https://github.com/user-attachments/assets/2f8d7503-dfa4-41f9-8730-9ba9713b53f5)
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Aug 15, 2024
@nicobytes nicobytes moved this from Internal QA to Done in dotCMS - Product Planning Aug 15, 2024
@nicobytes nicobytes changed the title Upgrade StoryBook Fix the broken stories Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicobytes nicobytes

Labels
Merged QA : Not Needed Team : Falcon Type : Task
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(storybook): upgrade storybook dotCMS/core
1 participant
@nicobytes