Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color in the Calendar Picker on Experiments #29472

Closed
nicobytes opened this issue Aug 6, 2024 · 1 comment · Fixed by #29615
Closed

Color in the Calendar Picker on Experiments #29472

nicobytes opened this issue Aug 6, 2024 · 1 comment · Fixed by #29615
Labels
Gardening Day QA : Approved Release : 24.08.27 Custom templates and loggin fixes Team : Falcon Type : Defect

Comments

@nicobytes
Copy link
Contributor

nicobytes commented Aug 6, 2024 •
edited
Loading

Problem Statement

The date selection buttons are the wrong color.

Screenshots

Original Updated
Screenshot 2024-08-16 at 11 38 48 AM Screenshot 2024-08-16 at 11 37 42 AM

Steps to Reproduce

Implement Experiments in Dev mode

First, reproduce this steps to load experiments in dev mode

  1. You need to have dotcms running (docker-file with dotcms, elasticsearch and postgresql)
  2. Go to core/docker/docker-compose-examples/analytics/docker-compose.yml and run that docker-compose.
  3. After the docker-compose loads, In dotCMS, go to Settings => Apps => Analytics Integration
  4. Fill the fields with this information
    clientId: analytics-customer-customer1
    Secret: testsecret
    Analytics Config URL: http://host.docker.internal:8088/c/customer1/cluster1/keys
    Analytics Write URL use: http://host.docker.internal:8081/api/v1/event
    Analytics Read URL use: http://host.docker.internal:4001/
    and save it

Second, select a date

  1. Go to pages
  2. Select a page
  3. Go to A/B Testing Option
  4. Create a new experiment
  5. Go to Scheduling section and click on Setup button
  6. Select a date
2024-08-06.15-27-53.mp4

Acceptance Criteria

Buttons with the proper colors.

dotCMS Version

lastest

Proposed Objective

User Experience

Proposed Priority

Priority 4 - Trivial

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@nicobytes nicobytes self-assigned this Aug 6, 2024
@nicobytes nicobytes moved this from New to Gardening Day Backlog in dotCMS - Product Planning Aug 6, 2024
@nicobytes nicobytes linked a pull request Aug 16, 2024 that will close this issue
chore(dotcms-ui): fix color #29615
Merged
3 tasks
@nicobytes nicobytes mentioned this issue Aug 16, 2024
Merged
3 tasks
@nicobytes nicobytes moved this from Gardening Day Backlog to In Review in dotCMS - Product Planning Aug 16, 2024
@nicobytes nicobytes mentioned this issue Aug 16, 2024
Closed
github-merge-queue bot pushed a commit that referenced this issue Aug 16, 2024
@nicobytes
chore(dotcms-ui): fix color (#29615)
adab97d 
### Parent Issue

#29472

### Proposed Changes
* Fix icon color

### Checklist
- [x] Tests
- [x] Translations
- [x] Security Implications Contemplated (add notes if applicable)

### Screenshots
Original             |  Updated
:-------------------------:|:-------------------------:
<img width="641" alt="Screenshot 2024-08-16 at 11 38 48 AM"
src="https://github.com/user-attachments/assets/69233b42-d4b0-4523-94bb-babe503b8fa2">
| <img width="632" alt="Screenshot 2024-08-16 at 11 37 42 AM"
src="https://github.com/user-attachments/assets/80eae706-2520-4e24-a14c-d9536e9c410b">
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Aug 16, 2024
@nicobytes nicobytes removed their assignment Aug 20, 2024
@nicobytes nicobytes moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Aug 20, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on trunk_386274d, Docker, macOS 14.5, FF v126.0.1

@josemejias11 josemejias11 added QA : Approved Release : 24.08.27 Custom templates and loggin fixes labels Aug 21, 2024
@josemejias11 josemejias11 moved this from QA - In Progress to Done in dotCMS - Product Planning Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Gardening Day QA : Approved Release : 24.08.27 Custom templates and loggin fixes Team : Falcon Type : Defect
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(dotcms-ui): fix color dotCMS/core
2 participants
@nicobytes @josemejias11