-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Playground locks up when opening endpoint with multipart form #29211
Comments
I attached another example of my browser infinitely fetching openapi.json. API_error.mp4 |
@wezell had suggested that this might be fixed by updating our Swagger js bundle. I've been subjecting this idea to some preliminary tests, though I'm not sure I'm doing so in the correct fashion. My method:
Unfortunately, this did not solve it. However, it may be that my method is not exhaustive of the various hooks that go into the API Playground, especially considering the use of plugins via Maven/jersey/et al. I'll try to drum up some feedback on this. |
I tried again, but this time I also cleared my whole cache and it worked! Multipart issue gone. Important note is that the CSS file also needs to be updated in this process, or else the titles end up looking an awful mess. So, I think we should also add some params to the three paths inside of I can wrangle up a PR later today. |
### Proposed Changes * Updates three Swagger UI generated JavaScript files * All three were taken as-is from the current `swagger-ui` repo's [`/dist` folder](https://github.com/swagger-api/swagger-ui/tree/master/dist). * Adds version URL params to the `index.jsp` file to spare users having to clear cache ### Checklist - [ ] Tests - [ ] Translations - [ ] Security Implications Contemplated (add notes if applicable) - [ ] Any further considerations about whether they ought to have come from `swagger-ui-dist` instead of the traditional `swagger-ui`, etc. ### Screenshots ![image](https://github.com/user-attachments/assets/dffb9bbe-1608-4a9c-b1a2-d2078f1590b8)
### Proposed Changes * Updates three Swagger UI generated JavaScript files * All three were taken as-is from the current `swagger-ui` repo's [`/dist` folder](https://github.com/swagger-api/swagger-ui/tree/master/dist). * Adds version URL params to the `index.jsp` file to spare users having to clear cache ### Checklist - [ ] Tests - [ ] Translations - [ ] Security Implications Contemplated (add notes if applicable) - [ ] Any further considerations about whether they ought to have come from `swagger-ui-dist` instead of the traditional `swagger-ui`, etc. ### Screenshots ![image](https://github.com/user-attachments/assets/dffb9bbe-1608-4a9c-b1a2-d2078f1590b8)
IQA Passed Internal
iqa-api-playground-locks-up.mov |
Parent Issue
No response
Problem Statement
Opening up any Swagger UI endpoint in the API Playground that has a multipart form component causes the browser to hang.
Screen.Recording.2024-07-12.at.12.02.33.PM.mov
I'm not sure what could be causing it, though the lockup is clearly caused by an infinite loop fetching
openapi.json
over and over.Steps to Reproduce
Acceptance Criteria
Multipart form endpoints should load the same as any other, without unexpected fetch behaviors.
dotCMS Version
Trunk, 24.07.05
Proposed Objective
Documentation
Proposed Priority
Priority 3 - Average
External Links... Slack Conversations, Support Tickets, Figma Designs, etc.
No response
Assumptions & Initiation Needs
No response
Quality Assurance Notes & Workarounds
No response
Sub-Tasks & Estimates
No response
The text was updated successfully, but these errors were encountered: