Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the Amount of Selected Categories and Add Show More/Show Less Functionality #29183

Closed
Tracked by #28493
oidacra opened this issue Jul 10, 2024 · 6 comments · Fixed by #29208
Closed
Tracked by #28493

Limit the Amount of Selected Categories and Add Show More/Show Less Functionality #29183

oidacra opened this issue Jul 10, 2024 · 6 comments · Fixed by #29208

Comments

@oidacra
Copy link
Member

oidacra commented Jul 10, 2024

Parent Issue

#28493

User Story

As a user, I need to see a maximum of two lines of selected categories in the input field, with a text button to show more if there are additional categories. When clicked, the button should display the hidden categories and change to "Show Less" to allow collapsing the view back to two lines.

Acceptance Criteria

  • Display a maximum of two lines of selected categories in the input field.
  • If there are more than two lines of categories, add a text button indicating the number of hidden categories (e.g., "9 more").
  • When the button is clicked, show all hidden categories and change the button text to "Show Less".
  • When the "Show Less" button is clicked, collapse the view back to two lines of categories.
  • Ensure the implementation is visually consistent with the design system.
  • Use PrimeNG components for displaying categories and managing the show more/less functionality.
  • Write unit tests to cover the new functionality.
  • Ensure the implementation does not introduce any new bugs or regressions.

Proposed Objective

User Experience Enhancement

Proposed Priority

Priority 2 - Important

dotCMS Version

master

External Links

Collapsed

Screenshot 2024-07-10 at 12 12 05 PM # Expanded Screenshot 2024-07-10 at 12 12 17 PM

Assumptions & Initiation Needs

Quality Assurance Notes & Workarounds

@oidacra oidacra moved this from New to Next 1-3 Sprints in dotCMS - Product Planning Jul 10, 2024
@oidacra oidacra changed the title Limit the ammount of selected categories (add show more) Limit the Amount of Selected Categories and Add Show More/Show Less Functionality Jul 10, 2024
@nicobytes nicobytes self-assigned this Jul 11, 2024
@nicobytes nicobytes moved this from Next 1-3 Sprints to Current Sprint Backlog in dotCMS - Product Planning Jul 11, 2024
@dsilvam dsilvam moved this from Current Sprint Backlog to Next 1-3 Sprints in dotCMS - Product Planning Jul 11, 2024
@nicobytes nicobytes self-assigned this Jul 11, 2024
@john-thomas-dotcms john-thomas-dotcms moved this from Next 1-3 Sprints to Current Sprint Backlog in dotCMS - Product Planning Jul 11, 2024
@nicobytes nicobytes moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Jul 11, 2024
@nicobytes nicobytes linked a pull request Jul 11, 2024 that will close this issue
3 tasks
@oidacra oidacra moved this from In Progress to In Review in dotCMS - Product Planning Jul 12, 2024
@oidacra oidacra moved this from In Review to Internal QA in dotCMS - Product Planning Jul 12, 2024
@oidacra oidacra added the Merged label Jul 12, 2024
@oidacra oidacra assigned oidacra and unassigned nicobytes Jul 12, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 12, 2024
### Parent Issue

#29183

### Proposed Changes

* Create a new component to handle the category list as chips.
* Add the necessary logic to display a btn with a maximum number of
chips.

### Checklist
- [x] Tests
- [x] Translations
- [x] Security Implications Contemplated (add notes if applicable)


### Screenshots



https://github.com/user-attachments/assets/c2f20ec9-c420-4336-8cf4-8f01c6af55b4
@oidacra oidacra reopened this Jul 12, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Jul 12, 2024
@oidacra oidacra moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Jul 12, 2024
@oidacra oidacra moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Jul 12, 2024
@oidacra
Copy link
Member Author

oidacra commented Jul 12, 2024

IQA Passed

@bryanboza
Copy link
Member

We need some work here, tested on trunk [ trunk_20af29a ] // Docker // FF

We are getting an error in console here and we are unable to see the changes

Image

@bryanboza bryanboza moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning Jul 12, 2024
@bryanboza bryanboza moved this from QA - In Progress to QA - Rejected in dotCMS - Product Planning Jul 12, 2024
@oidacra
Copy link
Member Author

oidacra commented Jul 12, 2024

Sorry for not specifying, this is only for the new Edit Contentlet @dsilvam @bryanboza

Screenshot 2024-07-12 at 5 58 52 PM

@bryanboza bryanboza moved this from QA - Rejected to QA - In Progress in dotCMS - Product Planning Jul 15, 2024
@josemejias11
Copy link
Contributor

Failed: Tested on trunk_430f4c7, Docker, macOS 14.5, FF v126.0.1

  1. After selecting all of the parent cats and removing them from the list line, the cats remains selected on the column categories selector.

  2. Removing the cats one by one should move the text to the far left side of the line and not leave padding.

Screen.Recording.2024-07-15.at.3.42.53.PM.mov
  1. Line should be removed after deleting all the cats
    Screenshot 2024-07-15 at 3 47 18 PM

@josemejias11 josemejias11 moved this from QA - In Progress to QA - Rejected in dotCMS - Product Planning Jul 15, 2024
@dsilvam
Copy link
Contributor

dsilvam commented Jul 15, 2024

@josemejias11 the remove is out of the scope of this card and actually part of another card. This is about the "Show More / Show Less" based on the number of lines.

@josemejias11
Copy link
Contributor

Approved: Tested on master_d501a60, Docker, macOS 14.5, FF v126.0.1

@josemejias11 josemejias11 moved this from QA - Rejected to Done in dotCMS - Product Planning Jul 16, 2024
@oidacra oidacra closed this as completed Jul 18, 2024
@github-project-automation github-project-automation bot moved this from Done to Internal QA in dotCMS - Product Planning Jul 18, 2024
@dsilvam dsilvam moved this from Internal QA to Done in dotCMS - Product Planning Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment