Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Version of CLI along with Header #28594

Closed
Tracked by #28378
damen-dotcms opened this issue May 17, 2024 · 3 comments · Fixed by #28853
Closed
Tracked by #28378

Send Version of CLI along with Header #28594

damen-dotcms opened this issue May 17, 2024 · 3 comments · Fixed by #28853

Comments

@damen-dotcms
Copy link
Contributor

Parent Issue

#28378

Task

We want to send the version of the CLI along with the Headers when making a call to an instance of dotCMS.

At some point in the future, we'll want the dotCMS instance to be able to look at the headers and respond, "You're using an out of date version of the CLI, time up upgrade!"

But right now, we just want to include the version in the headers so that we won't get into a spot where we can't add that response improvement to dotCMS in the future.

Proposed Objective

Same as Parent Issue

Proposed Priority

Same as Parent Issue

Acceptance Criteria

No response

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@nollymar nollymar moved this from New to Next 1-3 Sprints in dotCMS - Product Planning May 22, 2024
@nollymar nollymar moved this from Next 1-3 Sprints to Current Sprint Backlog in dotCMS - Product Planning May 29, 2024
@fabrizzio-dotCMS fabrizzio-dotCMS self-assigned this Jun 10, 2024
@fabrizzio-dotCMS fabrizzio-dotCMS moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Jun 10, 2024
fabrizzio-dotCMS added a commit that referenced this issue Jun 11, 2024
@fabrizzio-dotCMS fabrizzio-dotCMS linked a pull request Jun 12, 2024 that will close this issue
fabrizzio-dotCMS added a commit that referenced this issue Jun 12, 2024
fabrizzio-dotCMS added a commit that referenced this issue Jun 12, 2024
fabrizzio-dotCMS added a commit that referenced this issue Jun 13, 2024
fabrizzio-dotCMS added a commit that referenced this issue Jun 13, 2024
fabrizzio-dotCMS added a commit that referenced this issue Jun 13, 2024
@nollymar nollymar moved this from In Progress to In Review in dotCMS - Product Planning Jun 13, 2024
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Jun 13, 2024
@nollymar nollymar reopened this Jun 14, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Jun 14, 2024
@nollymar nollymar moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Jun 14, 2024
@spbolton
Copy link
Contributor

spbolton commented Jun 18, 2024

Bug introduced in Native build. #28915
Internal QA only done on Java Version, this should be retested after above bug is fixed.

@spbolton spbolton moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Jun 25, 2024
@github-project-automation github-project-automation bot moved this from QA - Backlog to Internal QA in dotCMS - Product Planning Jun 25, 2024
@nollymar nollymar moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Jun 25, 2024
@fabrizzio-dotCMS
Copy link
Contributor

you can set a proxy in front of dotCMS to intercept all apis call using Charles for example
You can also validate that the command dotCLI status prints the cli version

@bryanboza
Copy link
Member

Fixed, tested on trunk // latest CLI version

@bryanboza bryanboza moved this from QA - Backlog to Done in dotCMS - Product Planning Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants