Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle resource needs some improvements #27782

Closed
bryanboza opened this issue Mar 1, 2024 · 3 comments · Fixed by #29825
Closed

Bundle resource needs some improvements #27782

bryanboza opened this issue Mar 1, 2024 · 3 comments · Fixed by #29825

Comments

@bryanboza
Copy link
Member

bryanboza commented Mar 1, 2024

Parent Issue

Related to #26201

Problem Statement

When you are deleting a bundle, we always are returning a 200 in the response with the follow message
"entity": "Removing bundles in a separated process, the result of the operation will be notified". Then does not matter if the bundle was deleted or not.

At the response level, we are unable to know if we delete the bundle or not. We need to return a 404 error and the corresponding message in case the bundle does not exist.

Also, if you don't send body in that request, we are returning a 500 exception with a NPE in the log, we need to catch this exceptions and return the 400 (bad request) errror indicating the problem.
Here the log:
https://gist.github.com/bryanboza/21b5a4cf30950ebdee530b6117d38fbb
image

Steps to Reproduce

  • Try to delete bundles following each case mentioned above

Acceptance Criteria

  • Need to fix the exceptions
  • Need to add postman test to each case

dotCMS Version

Tested on master // Docker // FF

Proposed Objective

Quality Assurance

Proposed Priority

Priority 2 - Important

Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label May 30, 2024
@prestonso
Copy link

@bryanboza Is this issue still open?

@prestonso prestonso added the OKR : Quality Assurance Owned by Bryan label Jul 17, 2024
@fmontes fmontes moved this from New to Gardening Day Backlog in dotCMS - Product Planning Aug 27, 2024
@freddyDOTCMS freddyDOTCMS self-assigned this Aug 30, 2024
@freddyDOTCMS freddyDOTCMS moved this from Gardening Day Backlog to QA - In Progress in dotCMS - Product Planning Aug 30, 2024
@freddyDOTCMS freddyDOTCMS moved this from QA - In Progress to In Review in dotCMS - Product Planning Aug 30, 2024
@freddyDOTCMS freddyDOTCMS moved this from QA - In Progress to QA - Backlog in dotCMS - Product Planning Sep 3, 2024
@freddyDOTCMS freddyDOTCMS removed their assignment Sep 3, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on dotcms-postman/src/main/resources/postman/Bundle_Resource.postman_collection.json, Postman, macOS 14.5

@josemejias11 josemejias11 moved this from QA - In Progress to Done in dotCMS - Product Planning Sep 5, 2024
@github-project-automation github-project-automation bot moved this from Done to Internal QA in dotCMS - Product Planning Oct 15, 2024
@erickgonzalez erickgonzalez moved this from Internal QA to Done in dotCMS - Product Planning Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants