Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean mod_date after push remove action #26417

Open
bryanboza opened this issue Oct 10, 2023 · 2 comments
Open

Clean mod_date after push remove action #26417

bryanboza opened this issue Oct 10, 2023 · 2 comments

Comments

@bryanboza
Copy link
Member

bryanboza commented Oct 10, 2023

Problem Statement

Currently, after performing a push remove action in dotCMS, the mod_date field is not being cleared. This causes issues when trying to send the dependency again, as the system recognizes that the mod_date has not been updated and does not allow the dependency to be pushed.

Steps to Reproduce

  • Login as admin
  • Push some thing with dependencies (Experiment, relationship)
  • Perform a push remove action in dotCMS for a specific dependency.
  • Check the mod_date field for the dependency.

Acceptance Criteria

  • After performing a push remove action, the mod_date field for the dependency should be cleared.
  • The system should allow the dependency to be pushed again without any issues.

dotCMS Version

Tested on master // Docker // FF

Proposed Objective

Quality Assurance

Proposed Priority

Priority 2 - Important

Copy link

github-actions bot commented Jan 9, 2024

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Jan 9, 2024
@john-thomas-dotcms john-thomas-dotcms moved this from New to Gardening Day Backlog in dotCMS - Product Planning Jul 8, 2024
@freddyDOTCMS freddyDOTCMS self-assigned this Aug 30, 2024
@freddyDOTCMS freddyDOTCMS moved this from Gardening Day Backlog to In Progress in dotCMS - Product Planning Aug 30, 2024
@freddyDOTCMS freddyDOTCMS moved this from In Progress to Gardening Day Backlog in dotCMS - Product Planning Aug 30, 2024
@dsilvam dsilvam assigned dsilvam and unassigned freddyDOTCMS Sep 6, 2024
@dsilvam dsilvam moved this from Gardening Day Backlog to In Progress in dotCMS - Product Planning Sep 6, 2024
@dsilvam
Copy link
Contributor

dsilvam commented Sep 6, 2024

The actual fix here shouldn't involve the mod_date since you're not modifying the asset on the sender, you're just push removing it, which again should not alter the mod_date. The fix here involves registering the operation type when saving the asset in our push history table to then filter out any previous pushes which operation type was push-remove from the decision.
The other option is just not insert the asset in the history when it's a push-remove, but requires more thinking than a GD issue.
In general this is more work than considered to be a GD issue. Removing the label and putting it in the backlog.

@dsilvam dsilvam moved this from In Progress to Future in dotCMS - Product Planning Sep 6, 2024
@dsilvam dsilvam removed their assignment Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Future
Development

No branches or pull requests

5 participants