Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lodash from core-web #24842

Closed
2 tasks done
fmontes opened this issue May 5, 2023 · 7 comments · Fixed by #29716
Closed
2 tasks done

Remove lodash from core-web #24842

fmontes opened this issue May 5, 2023 · 7 comments · Fixed by #29716
Labels
Gardening Day Merged Note to QA OKR : Code Maintenance Owned by Erick OKR : Security & Privacy Owned by Mehdi QA : Approved QA : Passed Internal Release : 24.09.21 UVE // Java21 Team : Lunik Team : Scout Type : Task

Comments

@fmontes
Copy link
Member

fmontes commented May 5, 2023 •
edited by zJaaal
Loading

Parent Issue

No response

Task

lodash is problematic and has security issues, besides we're not using it a lot.

Let's remove lodash.

Proposed Objective

Security & Privacy

Proposed Priority

Priority 2 - Important

Acceptance Criteria

  • Remove lodash
  • Replace the used methods with vanilla JavaScript when possible (when no possible, let's talk in the frontend channel)

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@fmontes fmontes moved this from New to Current Sprint Backlog in dotCMS - Product Planning May 5, 2023
@damen-dotcms damen-dotcms added the OKR : Code Maintenance Owned by Erick label May 5, 2023
@fmontes fmontes moved this from Current Sprint Backlog to Next 1-3 Sprints in dotCMS - Product Planning Jun 5, 2023
@zJaaal zJaaal mentioned this issue Jun 13, 2023
Merged
3 tasks
@zJaaal zJaaal mentioned this issue Jun 23, 2023
Merged
3 tasks
@fmontes fmontes closed this as completed Jul 7, 2023
@fmontes fmontes moved this from Next 1-3 Sprints to Done in dotCMS - Product Planning Jul 7, 2023
@fmontes fmontes reopened this Aug 11, 2023
@fmontes fmontes moved this from Done to Future in dotCMS - Product Planning Aug 11, 2023
@mbiuki
Copy link
Contributor

mbiuki commented Mar 20, 2024

1- patch it
2- remove it

@fmontes fmontes moved this from Future to Next 1-3 Sprints in dotCMS - Product Planning Mar 20, 2024
@mbiuki
Copy link
Contributor

mbiuki commented May 22, 2024

It's a front-end component.

@mbiuki
Copy link
Contributor

mbiuki commented Jun 13, 2024

FYI, new version is .21
lodash/lodash#5851

@mbiuki mbiuki assigned mbiuki and fmontes and unassigned mbiuki Jun 13, 2024
@mbiuki
Copy link
Contributor

mbiuki commented Jun 13, 2024

@fmontes - please take it forward. Do we need to remove lodash, or should we upgrade to newer version?

@mbiuki mbiuki moved this from Next 1-3 Sprints to Gardening Day Backlog in dotCMS - Product Planning Jul 3, 2024
@fmontes fmontes moved this from Gardening Day Backlog to Next 1-3 Sprints in dotCMS - Product Planning Jul 9, 2024
@fmontes fmontes removed their assignment Jul 24, 2024
@nollymar nollymar moved this from Next 1-3 Sprints to Gardening Day Backlog in dotCMS - Product Planning Aug 14, 2024
@zJaaal zJaaal self-assigned this Aug 22, 2024
@zJaaal zJaaal moved this from Gardening Day Backlog to In Progress in dotCMS - Product Planning Aug 22, 2024
@zJaaal zJaaal linked a pull request Aug 22, 2024 that will close this issue
chore(gd): Remove lodash from core web #24842 #29716
Merged
@zJaaal zJaaal moved this from In Progress to In Review in dotCMS - Product Planning Aug 22, 2024
@zJaaal
Copy link
Contributor

zJaaal commented Aug 26, 2024 •
edited
Loading

Note to QA

Please be sure that all the portlets where the Template Builder is present, works as expected.

I removed the Old Template Builder code, because it had lodash code and therefore deleted all logic to render the old or the new template builder by checking the Feature Flag, so we need to test that Templates Portlet, Old Edit Mode work as expected with the Template Builder. New edit mode has been left as it is because it didn't has any feature flag logic nor references to the old template builder

github-merge-queue bot pushed a commit that referenced this issue Aug 26, 2024
@zJaaal
chore(gd): Remove lodash from core web #24842 (#29716)
fb1e248 
### Proposed Changes
* Replace `lodash` with native functions
* Remove unused and bloated code
* Remove the FF Checking to decided between old and new Template
Builder, since we are not supporting the old one anymore
* Remove old Template Builder from the code
* Change a `setTimeout` time from `250` to `350` to cover an unknown
edge case to prevent a bad UX animation to be seen by the user (This
change is UX related, does not affect any functionality)
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Aug 26, 2024
@zJaaal zJaaal removed their assignment Aug 26, 2024
@github-actions github-actions bot mentioned this issue Aug 26, 2024
Merged
@zJaaal zJaaal reopened this Aug 26, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Aug 26, 2024
@zJaaal zJaaal moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Aug 26, 2024
@KevinDavilaDotCMS KevinDavilaDotCMS self-assigned this Aug 27, 2024
@KevinDavilaDotCMS
Copy link
Contributor

Passed IQA

tested in master

Screen.Recording.2024-08-27.at.4.23.14.PM.mov

@KevinDavilaDotCMS KevinDavilaDotCMS moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Aug 27, 2024
@bryanboza
Copy link
Member

Fixed, I made a smoke validation on containers and pages and everything is working normally!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Gardening Day Merged Note to QA OKR : Code Maintenance Owned by Erick OKR : Security & Privacy Owned by Mehdi QA : Approved QA : Passed Internal Release : 24.09.21 UVE // Java21 Team : Lunik Team : Scout Type : Task
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(gd): Remove lodash from core web #24842 dotCMS/core
7 participants
@fmontes @bryanboza @nollymar @mbiuki @zJaaal @damen-dotcms @KevinDavilaDotCMS