Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify dotCMS generated contentlet system-wide for efficient thumbnail generation #23600

Closed
4 of 8 tasks
Tracked by #23599
fmontes opened this issue Dec 16, 2022 · 4 comments · Fixed by #25405 or #25601
Closed
4 of 8 tasks
Tracked by #23599

Unify dotCMS generated contentlet system-wide for efficient thumbnail generation #23600

fmontes opened this issue Dec 16, 2022 · 4 comments · Fixed by #25405 or #25601
Assignees
@jcastro-dotcms
Labels
QA : Approved Release : 23.08.16 Team : Lunik Type : Enhancement

Comments

@fmontes
Copy link
Member

fmontes commented Dec 16, 2022 •
edited by rjvelazco
Loading

Parent Issue

#23599

Task

As a stakeholder, I want to unify the thumbnail generation process across the system to optimize server performance and prevent the generation of multiple images for different pages.

We are using the RESTful Image Processing API to generate the thumbnails. And this is good, but the issue is that there are varying thumbnail URLs used across different sections of the system. This results in the generation of multiple thumbnails for the same image, which can put a significant load on the server when there are many contentlets.

What we need to do is make sure that everywhere in the system that has a contentlet thumbnail, we use the same image URL for that to prevent the system from generating new images for different pages.

Web Component

We already have a web component to render the thumbnail image, we are just not using it everywhere.

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

Acceptance Criteria

Use the dot-contentlet-thumbnail in all the sections of the system where we need to render a contentlet thumbnail.

Use the thumbnail web component in the following sections

  • Content search card view
  • Content search list view
  • Relationship field
  • Content palette
  • Edit page > Adds contentlet
  • Block editor (I think this is done, double check)
  • WYSIWYG image search
  • Add images field

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Sub-Tasks & Estimates

No response
@zulqarnainvd zulqarnainvd self-assigned this Jan 3, 2023
@damen-dotcms damen-dotcms moved this from New to Next in dotCMS - Product Planning Jan 26, 2023
@damen-dotcms damen-dotcms moved this from Next to Future in dotCMS - Product Planning Jan 26, 2023
@damen-dotcms damen-dotcms moved this from Future to Next Sprint in dotCMS - Product Planning Feb 1, 2023
@fmontes
Copy link
Member Author

fmontes commented Feb 14, 2023 •
edited
Loading

  1. Content search card and list
  2. Edit page adds contentlet
  3. Relationship field
  4. Block editor
  5. WYSIWYG image search
  6. Content palette
  7. Add images field
  8. Pages bookmark thumbnail

@fmontes fmontes changed the title CS: Fix the thumbnail in the card view Unify thumbnail URL in all places on the system Feb 21, 2023
@fmontes fmontes changed the title Unify thumbnail URL in all places on the system Unify dotCMS generated contentlet system-wide for efficient thumbnail generation Feb 21, 2023
@fmontes fmontes moved this from Next 1-3 Sprints to Current Sprint Backlog in dotCMS - Product Planning Feb 24, 2023
@fmontes fmontes mentioned this issue Mar 1, 2023
Closed
@fmontes fmontes moved this from Current Sprint Backlog to Next 1-3 Sprints in dotCMS - Product Planning Jun 5, 2023
wezell added a commit that referenced this issue Jun 30, 2023
@wezell
#23600 updating style
40b50ae
wezell added a commit that referenced this issue Jul 7, 2023
@wezell
#23600 unifies thumbnail size across a number of screens
a219e65
@fmontes
Copy link
Member Author

fmontes commented Jul 7, 2023

https://github.com/dotCMS/core/pull/25405/files

@fmontes fmontes linked a pull request Jul 7, 2023 that will close this issue
#23600 Use same thumbnail size everywhere part 1 #25405
Merged
wezell added a commit that referenced this issue Jul 7, 2023
@wezell
#23600 ImageEditor default
80c8905
@fmontes fmontes moved this from Next 1-3 Sprints to Current Sprint Backlog in dotCMS - Product Planning Jul 11, 2023
jcastro-dotcms pushed a commit that referenced this issue Jul 24, 2023
@wezell
#23600 Use same thumbnail size everywhere part 1 (#25405)
9e2c935 
* #23600 updating style

* #23600 unifies thumbnail size across a number of screens

* #23600 ImageEditor default
@jcastro-dotcms jcastro-dotcms moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Jul 24, 2023
@jcastro-dotcms jcastro-dotcms self-assigned this Jul 24, 2023
wezell added a commit that referenced this issue Jul 24, 2023
@wezell
#23600 fixes click on thumbnail issue
419e664
@wezell wezell linked a pull request Jul 24, 2023 that will close this issue
#23600 fixes click on thumbnail issue #25601
Merged
jcastro-dotcms pushed a commit that referenced this issue Jul 24, 2023
@wezell
#23600 fixes click on thumbnail issue (#25601)
8d344c7
@jcastro-dotcms
Copy link
Contributor

INTERNAL QA: PASSED

  • Docker Image: dotcms/dotcms:master_8d344c7_SNAPSHOT

Thumbnails show up just like in the PR's description: #25405 , and the tests explained in there were verified in the Docker image as well.

@jcastro-dotcms jcastro-dotcms moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Jul 25, 2023
@bryanboza bryanboza moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning Jul 28, 2023
@josemejias11
Copy link
Contributor

Approved QA - Tested on master_37bd1f0_SNAPSHOT // Docker // macOS 13.0 // FF v113.0

@josemejias11 josemejias11 moved this from QA - In Progress to Done in dotCMS - Product Planning Aug 2, 2023
@fmontes fmontes closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcastro-dotcms jcastro-dotcms

Labels
QA : Approved Release : 23.08.16 Team : Lunik Type : Enhancement
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
5 participants
@fmontes @dsilvam @jcastro-dotcms @zulqarnainvd @josemejias11