From e2c1a0e57669377469d9b2467528bb6750fcfc1f Mon Sep 17 00:00:00 2001
From: Victor Alfaro <victor.alfaro@dotcms.com>
Date: Tue, 13 Aug 2024 17:16:28 -0600
Subject: [PATCH] #29281: Applying feedback

---
 dotCMS/src/main/java/com/dotcms/ai/app/AppKeys.java    | 10 +++++-----
 .../main/java/com/dotcms/ai/util/OpenAIRequest.java    |  2 +-
 dotCMS/src/main/java/com/liferay/util/StringPool.java  |  2 ++
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/dotCMS/src/main/java/com/dotcms/ai/app/AppKeys.java b/dotCMS/src/main/java/com/dotcms/ai/app/AppKeys.java
index 7afdad1c380b..a40c57c959f8 100644
--- a/dotCMS/src/main/java/com/dotcms/ai/app/AppKeys.java
+++ b/dotCMS/src/main/java/com/dotcms/ai/app/AppKeys.java
@@ -1,5 +1,7 @@
 package com.dotcms.ai.app;
 
+import com.liferay.util.StringPool;
+
 public enum AppKeys {
 
     API_KEY("apiKey", null),
@@ -22,12 +24,12 @@ public enum AppKeys {
     IMAGE_MODEL_TOKENS_PER_MINUTE("imageModelTokensPerMinute", "0"),
     IMAGE_MODEL_API_PER_MINUTE("imageModelApiPerMinute", "50"),
     IMAGE_MODEL_MAX_TOKENS("imageModelMaxTokens", "0"),
-    IMAGE_MODEL_COMPLETION("imageModelCompletion",  AppKeys.FALSE),
+    IMAGE_MODEL_COMPLETION("imageModelCompletion",  StringPool.FALSE),
     EMBEDDINGS_MODEL_NAMES("embeddingsModelNames", null),
     EMBEDDINGS_MODEL_TOKENS_PER_MINUTE("embeddingsModelTokensPerMinute", "1000000"),
     EMBEDDINGS_MODEL_API_PER_MINUTE("embeddingsModelApiPerMinute", "3000"),
     EMBEDDINGS_MODEL_MAX_TOKENS("embeddingsModelMaxTokens", "8191"),
-    EMBEDDINGS_MODEL_COMPLETION("embeddingsModelCompletion",  AppKeys.FALSE),
+    EMBEDDINGS_MODEL_COMPLETION("embeddingsModelCompletion",  StringPool.FALSE),
     EMBEDDINGS_SPLIT_AT_TOKENS("com.dotcms.ai.embeddings.split.at.tokens", "512"),
     EMBEDDINGS_MINIMUM_TEXT_LENGTH_TO_INDEX("com.dotcms.ai.embeddings.minimum.text.length", "64"),
     EMBEDDINGS_MINIMUM_FILE_SIZE_TO_INDEX("com.dotcms.ai.embeddings.minimum.file.size", "1024"),
@@ -39,7 +41,7 @@ public enum AppKeys {
     EMBEDDINGS_CACHE_TTL_SECONDS("com.dotcms.ai.embeddings.cache.ttl.seconds", "600"),
     EMBEDDINGS_CACHE_SIZE("com.dotcms.ai.embeddings.cache.size", "1000"),
     EMBEDDINGS_DB_DELETE_OLD_ON_UPDATE("com.dotcms.ai.embeddings.delete.old.on.update", "true"),
-    DEBUG_LOGGING("com.dotcms.ai.debug.logging", AppKeys.FALSE),
+    DEBUG_LOGGING("com.dotcms.ai.debug.logging", StringPool.FALSE),
     COMPLETION_TEMPERATURE("com.dotcms.ai.completion.default.temperature", "1"),
     COMPLETION_ROLE_PROMPT(
             "com.dotcms.ai.completion.role.prompt",
@@ -52,8 +54,6 @@ public enum AppKeys {
     AI_MODELS_CACHE_TTL("com.dotcms.ai.models.supported.ttl", "28800"),
     AI_MODELS_CACHE_SIZE("com.dotcms.ai.models.supported.size", "64");
 
-    private static final String FALSE = "false";
-
     public static final String APP_KEY = "dotAI";
 
     public final String key;
diff --git a/dotCMS/src/main/java/com/dotcms/ai/util/OpenAIRequest.java b/dotCMS/src/main/java/com/dotcms/ai/util/OpenAIRequest.java
index d022156f15e3..093d706234b4 100644
--- a/dotCMS/src/main/java/com/dotcms/ai/util/OpenAIRequest.java
+++ b/dotCMS/src/main/java/com/dotcms/ai/util/OpenAIRequest.java
@@ -54,7 +54,7 @@ public static void doRequest(final String urlIn,
                                  final OutputStream out) {
 
         if (!appConfig.isEnabled()) {
-            AppConfig.debugLogger(OpenAIRequest.class, () -> "dotAI is not enabled and will not send request.");
+            AppConfig.debugLogger(OpenAIRequest.class, () -> "App dotAI is not enabled and will not send request.");
             throw new DotRuntimeException("App dotAI config without API urls or API key");
         }
 
diff --git a/dotCMS/src/main/java/com/liferay/util/StringPool.java b/dotCMS/src/main/java/com/liferay/util/StringPool.java
index 80b5d2c29f57..478ef31f3dc6 100644
--- a/dotCMS/src/main/java/com/liferay/util/StringPool.java
+++ b/dotCMS/src/main/java/com/liferay/util/StringPool.java
@@ -89,4 +89,6 @@ public class StringPool {
 
 	public static final String TRUE = Boolean.TRUE.toString();
 
+	public static final String FALSE = Boolean.FALSE.toString();
+
 }