Submodules are not tagged correctly.

[HappyHacker123]

What version of GraphJin are you using? graphjin version

v3.0.1

Have you tried reproducing the issue with the latest release?

Yes.

Steps to reproduce the issue.

Run go get github.com/dosco/graphjin/core/v3 v3.0.31

Expected behaviour and actual result.

It seems that current graphjin has mutliple submodules with their own go.mod, for example, core and cmd.
However, it seems that the submodules are not properly tagged. According to Go Modules standard , submodule should be tagged like relative-path-to-root/vX.X.X.
At now, when trying to import package github.com/dosco/graphjin/core, downstream project would have to depend on pseudo-version of it and cannot get a valid tag version.

	github.com/dosco/graphjin/core/v3 v3.0.0-20240713020306-3fb8338c363e 

To address this, i think it's better to tag submodules properly according to Go standard, for example, releasing a tag `core/v3.0.31``, so that downstream project can use tag version to import the submodule in go.mod.

[HappyHacker123]

Could you please take a look at this issue @dosco ? Many thanks :)

[dosco]

i can't seem to get go to use go.work also where did you read that relative paths are allows they don't seem to be. I switched to using github.com/dosco/graphjin/core/v3 v3.0.31 in the various go.mod files but i get github.com/dosco/graphjin/core/v3: reading github.com/dosco/graphjin/core/go.mod at revision core/v3.0.31: unknown revision core/v3.0.31

[dosco]

i tried some ideas to fix the issue even upgraded a ton of packages and go versions but not luck

/tmp/test > go get github.com/dosco/graphjin/core/v3
go: added github.com/dosco/graphjin/core/v3 v3.0.0-20240906013641-429f6f3f68d1
go: added github.com/hashicorp/golang-lru v0.5.4
go: added golang.org/x/sync v0.8.0

/tmp/test > go get github.com/dosco/graphjin/core/[email protected]
go: downloading github.com/dosco/graphjin v3.0.33+incompatible
go: module github.com/dosco/[email protected] found (v3.0.33+incompatible), but does not contain package github.com/dosco/graphjin/core/v3

[dosco]

wonder if we need to restructure the repo to make this work?

[HappyHacker123]

@dosco Thanks so much for your response! Sorry for the late reply.

i can't seem to get go to use go.work also where did you read that relative paths are allows they don't seem to be. I switched to using github.com/dosco/graphjin/core/v3 v3.0.31 in the various go.mod files but i get github.com/dosco/graphjin/core/v3: reading github.com/dosco/graphjin/core/go.mod at revision core/v3.0.31: unknown revision core/v3.0.31

The problem lies in you haven't released a tag version for github.com/dosco/graphjin/core. Since core has its own go.mod file, it requires its own version tag. Currently, the existing versions apply to dosco/graphjin, but not specifically to dosco/graphjin/core/. So the v3.0.31 tag released now is for github.com/dosco/graphjin not for github.com/dosco/graphjin/core .

wonder if we need to restructure the repo to make this work?

There's no need to alter the project structure; you just need to release a tag for core, such as core/v3.0.31. This will allow Go Modules to recognize the version as belonging to core.

[HappyHacker123]

You can refer to this link

[dosco]

thanks spent hours did not find this doc. i'll try this so will release a /vVersion tag per package. i ended up removing go.work and switched to using replace will go back and try using go.work

[HappyHacker123]

Thanks for your effort!