Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Quick Check data structures #556

Open
davidstanke opened this issue Mar 18, 2024 · 0 comments
Open

Consolidate Quick Check data structures #556

davidstanke opened this issue Mar 18, 2024 · 0 comments
Labels

Comments

@davidstanke
Copy link
Collaborator

davidstanke commented Mar 18, 2024

The data structures for Quick Check are kinda all over the place -- it's a combination of imported global constants (e.g. src/lib/data/...), inline global constants (e.g. const metrics_details=[...] within MetricsQuestion.svelte) and user-entered data, which correlate to those constants.

I think we could make this cleaner and more maintainable by storing all of this in one (well-organized) object. The constants can be populated at build time, and the user data can be mutated at run time. (I don't see any problem with mixing both in one data structure[?]).

This should probably be started after #550 is finished. (It probably should have been done before that was started, but I already started it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant