Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intellij/Pycharm: Quick definition does not work properly when plugin enabled #269

Open
FeralFox opened this issue Apr 2, 2020 · 2 comments
Labels
Milestone

Comments

@FeralFox
Copy link

FeralFox commented Apr 2, 2020

What I did

  • Enabling the plugin in IntelliJ IDEA
  • Show quick definition of a function or class

What happened

The quick definition shows the content of the file containing the selected function.
image

What I wanted to happen

The quick definition only shows the content of the selected function

image

My environment

  • IntelliJ IDEA 2019.3.4, Live Coding plugin enabled
  • When disabling the plugin, quick definition works as expected again
@donkirkby
Copy link
Owner

Thanks for the bug report, I can reproduce the problem here. In case I forget, the keyboard shortcut for quick definitions is Ctrl+Shift+I.

@donkirkby donkirkby added the bug label Apr 3, 2020
@donkirkby donkirkby added this to the Near future milestone Apr 3, 2020
@donkirkby donkirkby modified the milestones: Near future, 4.2 Jun 23, 2020
@donkirkby
Copy link
Owner

donkirkby commented Jul 1, 2020

I'm reverting the fix for this, because I can't replace the default editor. It ends up listing two editors at the bottom of the window.

It looks like the only way to show the definition instead of the whole file is if the editor provider is an instance of TextEditorProvider. Otherwise, the whole file is displayed and foundElement isn't used.

Commit 04355ff converted SplitFileEditorProvider to be a subclass of TextEditorProvider, and it did start displaying just the function definition. However, I couldn't hide the default editor, because now my replacement is also a subclass of DefaultPlatformFileEditorProvider.

I'll post a question in the forum to see if there's some other way to get the quick definition working.

@donkirkby donkirkby reopened this Jul 1, 2020
donkirkby added a commit that referenced this issue Jul 1, 2020
…orProvider, rolling back the fix for #269.

Reverts commit 04355ff.
@donkirkby donkirkby modified the milestones: 4.2, Near future Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants