-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to be used with any DOM implementation #124
Comments
Deferring this for now, it's harder than it sounds. Currently canjs maps can/util/vdom/vdom to load on the server, so we'd want to disable that somehow when using an alternative implementation. |
This should be possible now with can 3.0. We no longer shim any libraries. |
Just a matter of picking an API now. We need to be able to receive a const ssr = require("done-ssr");
const { JSDOM } = require("jsdom");
function makeDom() {
var dom = new JSDOM();
return dom.window;
}
const render = ssr({}, {
dom: makeDom
}); |
cc @justinbmeyer what do you think about the above API? |
Currently we rely on
can/util/vdom/vdom
but it would be nice if it could work with jsdom since that is more robust.The text was updated successfully, but these errors were encountered: