-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wishlist: File information in overlay #59
Comments
…closed. Still work to do with potentially managing the popstate handler for files too. Potentially addresses the main problem in #59.
Minor changes for this are in place, the title and the URL are updated when the preview is open. Appreciate that might not be enough but hopefully it's a decent enough start. This can be viewed, along with #60 using the a build from https://github.com/dom111/webdav-js/tree/feature/file-information-on-preview |
There's probably different schools of thought, but I don't think that the image itself should be pushed into the path -- after all, the user's "browser cursor" is not on the image itself, it is on the directory view at the position where it's viewing that image. So what I'd do about the paths is not to push the path in (as that doesn't survive a refresh), but just push a fragment identifier, say, |
…hen closed. Still work to do with potentially managing the `popstate` handler for files too. Potentially addresses the main problem in #59.
…hen closed. Still work to do with potentially managing the `popstate` handler for files too. Potentially addresses the main problem in #59.
When a popover is opened in a collection, there is no indication to the user which file is being displayed.
I'd suggest that the page title is updated temporarily, and that the file name be shown above or below the image / movie.
The text was updated successfully, but these errors were encountered: