Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReducedFunctional.optimize_tape should replace self.tape with the optimized tape without modifying the original self.tape. #170

Open
JHopeCollins opened this issue Oct 1, 2024 · 0 comments
Open

ReducedFunctional.optimize_tape should replace self.tape with the optimized tape without modifying the original self.tape. #170

JHopeCollins opened this issue Oct 1, 2024 · 0 comments

Comments

@JHopeCollins
Copy link
Contributor

This means that if you call ReducedFunctional.optimize_tape on one ReducedFunctional, it will not modify the tape of any other ReducedFunctional.

Potentially the API should change to the optimize_tape returns the new (optimized) tape, rather than modifying self.tape.
@JHopeCollins JHopeCollins changed the title ReducedFunctional.optimize_tape should create replace self.tape with the optimized tape without modifying the original self.tape. ReducedFunctional.optimize_tape should replace self.tape with the optimized tape without modifying the original self.tape. Oct 1, 2024
@JHopeCollins JHopeCollins mentioned this issue Oct 11, 2024
Closed
@JHopeCollins JHopeCollins linked a pull request Oct 11, 2024 that will close this issue
ReducedFunctional.optimize_tape will optionally _replace_ self.tape with the optimized tape, without modifying original tape. #171
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@JHopeCollins