Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not send emails to blog author if comments_subscription is disabled #130

Open
mthu opened this issue Nov 25, 2020 · 0 comments
Open

Comments

@mthu
Copy link

mthu commented Nov 25, 2020

While send_subscriber_mails function contains a condition

if(!$this->getConf('comments_subscription')) return;

which stops just after the notification to the author is sent (but not to the subscribers), it is not called from save (caller function) if subscription is disabled
$this->send_subscriber_mails($comment);

This combination makes the case "send to the authors only" unavailable. It allows either all users to get subscribed, or nothing.

I guess this is not intended behavior, probably the send_subscriber_mails should be called in every case, independently on comments_subscription setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant