-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Исправляет и дополняет доку Promise.any()
#5557
Open
vitya-ne
wants to merge
3
commits into
doka-guide:main
Choose a base branch
from
vitya-ne:fix-promise-any
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TatianaFokina
added
улучшение
Доработка существующего
ошибка
Что-то критичное и мешает
labels
Nov 21, 2024
TatianaFokina
approved these changes
Nov 21, 2024
Inventoris
reviewed
Nov 22, 2024
Inventoris
reviewed
Nov 25, 2024
@@ -137,12 +137,14 @@ Promise.any([promise1, promise2]) | |||
.catch(error => { | |||
console.error(error) | |||
// AggregateError: All promises were rejected | |||
console.log(error.errors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Супер! Теперь прозрачно и понятно :)
Превью контента из 67c6288 опубликовано. |
Inventoris
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Красота!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
В описании выполнения
Promise.any()
в случае если один из промисов завершается с ошибкой, методthen()
упоминается как "обработчик ошибок then()". Скорее всего это ошибка при копипасте.Кроме это я добавил из чего будет состоять
AggregateError
в случае когда оба промиса завершаются с ошибкойCloses #5556
Чек-лист
/css/color/
,/tools/json/
,/tools/gulp/#kak-ponyat
)images/example.png
,demos/example/
,../demos/example/
)