Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(world): make fields as keys in events where possible #2228

Closed
lambda-0x opened this issue Jul 29, 2024 · 3 comments · Fixed by dojoengine/dojo-core#12
Closed

feat(world): make fields as keys in events where possible #2228

lambda-0x opened this issue Jul 29, 2024 · 3 comments · Fixed by dojoengine/dojo-core#12
Labels
dojo-core cairo core tasks enhancement New feature or request

Comments

@lambda-0x
Copy link
Collaborator

lambda-0x commented Jul 29, 2024 •
edited
Loading

Since having fields as keys can help retrieving events more granular.

In future torii might benefit from this when we add features like whitelist based models/system indexing.
@lambda-0x lambda-0x added the bug Something isn't working label Jul 29, 2024
@lambda-0x lambda-0x changed the title [BUG] feat(world): make fields as keys in event where possible Jul 29, 2024
@lambda-0x lambda-0x changed the title feat(world): make fields as keys in event where possible feat(world): make fields as keys in events where possible Jul 29, 2024
@lambda-0x lambda-0x added enhancement New feature or request dojo-core cairo core tasks and removed bug Something isn't working labels Jul 29, 2024
@remybar
Copy link
Contributor

remybar commented Aug 7, 2024

Hi @lambda-0x !
Do you mean adding #[key] attribute on event struct fields in the world contract when it makes sense to do it ?

@lambda-0x
Copy link
Collaborator Author

yes, exactly!

@remybar remybar mentioned this issue Aug 9, 2024
Closed
10 tasks
@ScottyDavies
Copy link

Hello @lambda-0x, please can i work on this?

@remybar remybar mentioned this issue Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dojo-core cairo core tasks enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: event fields annotated as keys remybar/dojo-core
Event fields as key remybar/dojo
3 participants
@remybar @lambda-0x @ScottyDavies