Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flapping test coverage. #198

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Fix flapping test coverage. #198

merged 2 commits into from
Apr 22, 2020

Conversation

jmalloc
Copy link
Member

@jmalloc jmalloc commented Apr 22, 2020 •
edited
Loading

Fixes #188.

  • Add test for eventstore.Result.Next() failure in networkstream.server
  • Add test to ensure Queue.Track() does not block once queue.Run() has returned
  • Add test to ensure Request.Close() does not block once queue.Run() has returned

@jmalloc jmalloc self-assigned this Apr 22, 2020
@jmalloc jmalloc marked this pull request as ready for review April 22, 2020 04:40
@jmalloc jmalloc merged commit 6199005 into master Apr 22, 2020
@jmalloc jmalloc deleted the 188-flapping-coverage branch April 22, 2020 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jmalloc jmalloc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coverage flapping.
1 participant
@jmalloc