Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contextWithRmd for R Markdown #37

Merged
merged 2 commits into from
Sep 9, 2020
Merged

contextWithRmd for R Markdown #37

merged 2 commits into from
Sep 9, 2020

Conversation

ViktorVerstraelen
Copy link
Contributor

@ViktorVerstraelen ViktorVerstraelen commented Sep 9, 2020 •
edited by chvp
Loading

I added a contextWithRmd function. It is the same as the context function but it uses knitr::purl() to extract R code blocks from the input Rmd file. We decided to implement this in a seperate function to facilitate adding new functionality (such as showing the rendered Rmd) in the future. Fixes #26.

@bmesuere bmesuere requested a review from chvp September 9, 2020 12:09
chvp
chvp approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of duplication, but it isn't trivial to solve. Should be fixed when #36 is handled.

@chvp chvp merged commit 6dbb116 into dodona-edu:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chvp chvp chvp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Look into Rmd evaluation
2 participants
@ViktorVerstraelen @chvp