Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to a member function read() on string in ObjectSerializer.php:285 #102

Closed
BelloAM opened this issue Jun 4, 2020 · 13 comments
Closed

Comments

@BelloAM
Copy link

BelloAM commented Jun 4, 2020

I get this error whenever i run the EnvelopeApi\getDocument method. It seems that the $data being passed to the deserialize function is a string.

I managed to get it to work by changing line 285-287 to

if(is_string($data)){
    fwrite($file, $data);
}
else{
    while ($chunk = $data->read(200)) {
        fwrite($file, $chunk);
    } 
}

Unfortunately; this change is always removed when we deploy to our servers

@LarryKlugerDS
Copy link
Contributor

Thank you @BelloAM for this problem report.
I have filed bug report DCM-4285

@LarryKlugerDS
Copy link
Contributor

Note that the EnvelopeApi\getDocument method should be updated to not write to a local file. See issue #56

@fdiedler
Copy link

Hi,
I have the same problem since one week. When this bug will be fixed ?
Thanks

@LarryKlugerDS
Copy link
Contributor

Unfortunately we don't yet have a fix scheduled from the engineering group. I have asked them again.

@fdiedler
Copy link

fdiedler commented Jun 15, 2020

I am very embarrassed with this bug, we cannot retrieve contract file anymore and it blocks the onboarding of new clients in my company... Please correct it as soon as possible and thanks for asking them again about this bug. I think I am not the only people affected :)

Otherwise, It is possible to downgrade to a prior version without the bug ? And if so, which version ?

Thanks, and looking forward the fix

NB: I cannot use a quick and dirty fix because when I deploy my application on production, the fix will be removed as @BelloAM said.

@LarryKlugerDS
Copy link
Contributor

I am sorry that this is causing a problem for you.
The prior releases of the SDK are available from GitHub. They are also available from the PHP Packagist site.

@fdiedler
Copy link

Aie, I think I cannot downgrade because I use a wrapper :
tucker-eric/docusign-rest-client

So, I just removed the code that calls getDocument() method and I will wait for a fix and hope it will be soon :)

Thanks,

@wehostadm
Copy link

wehostadm commented Jul 2, 2020

Hi,

Just to say that I am also waiting for a fix for this bug as soon as possible.
It will be a shame and a waste of time if I need to recode the function getDocument()

Maybe use the quick fix of @BelloAM above and then do a better fix if needed ?

Thanks a lot for this DocuSign bundle.

@LarryKlugerDS
Copy link
Contributor

I've escalated the bug, but we don't yet have a schedule for the fix.

@cgsmith
Copy link

cgsmith commented Jul 3, 2020

Hi @LarryKlugerDS

Are pull requests welcomed for this? An option could be passed through to save contents to a variable.

@LarryKlugerDS
Copy link
Contributor

Hi @cgsmith ,
Re: pull requests -- thank you for asking!

We use a customized version of the Swagger CodeGen app to create all of the SDKs. We're working on open sourcing our customizations.

Today: if you make a pull request then our engineering team can use your ideas to change the underlying models used to produce the SDK.

In the future: you'll be able to directly propose a PR that would change the model that would change the SDK.

Regards,
Larry

@LarryKlugerDS
Copy link
Contributor

Good news: the engineering group reports that this issue has been fixed n the RC release 5.3.0-RC.

If you can, please test the release candidate to check that the fix works for you. Thank you.

The 5.3.0-RC (release candidate):

The PRs:

#108
#109

@LarryKlugerDS
Copy link
Contributor

No reply for 10 days. Closing. Please comment to re-open if there's still an issue. Thank you, Larry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants