From 20d0298e0c02c8b54760253370b629418046f273 Mon Sep 17 00:00:00 2001
From: "Alexander M. Turek" <me@derrabus.de>
Date: Sat, 1 Jan 2022 23:45:05 +0100
Subject: [PATCH] Provide failing test for readonly properties

---
 .../Models/ReadonlyProperties/Author.php      |  31 +++++
 .../Tests/Models/ReadonlyProperties/Book.php  |  51 ++++++++
 .../Models/ReadonlyProperties/SimpleBook.php  |  41 +++++++
 .../ORM/Functional/ReadonlyPropertiesTest.php | 111 ++++++++++++++++++
 4 files changed, 234 insertions(+)
 create mode 100644 tests/Doctrine/Tests/Models/ReadonlyProperties/Author.php
 create mode 100644 tests/Doctrine/Tests/Models/ReadonlyProperties/Book.php
 create mode 100644 tests/Doctrine/Tests/Models/ReadonlyProperties/SimpleBook.php
 create mode 100644 tests/Doctrine/Tests/ORM/Functional/ReadonlyPropertiesTest.php

diff --git a/tests/Doctrine/Tests/Models/ReadonlyProperties/Author.php b/tests/Doctrine/Tests/Models/ReadonlyProperties/Author.php
new file mode 100644
index 00000000000..901b9ed3005
--- /dev/null
+++ b/tests/Doctrine/Tests/Models/ReadonlyProperties/Author.php
@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Doctrine\Tests\Models\ReadonlyProperties;
+
+use Doctrine\ORM\Mapping\Column;
+use Doctrine\ORM\Mapping\Entity;
+use Doctrine\ORM\Mapping\GeneratedValue;
+use Doctrine\ORM\Mapping\Id;
+use Doctrine\ORM\Mapping\Table;
+
+#[Entity, Table(name: 'author')]
+class Author
+{
+    #[Column, Id, GeneratedValue]
+    private readonly int $id;
+
+    #[Column]
+    private readonly string $name;
+
+    public function getId(): int
+    {
+        return $this->id;
+    }
+
+    public function getName(): string
+    {
+        return $this->name;
+    }
+}
diff --git a/tests/Doctrine/Tests/Models/ReadonlyProperties/Book.php b/tests/Doctrine/Tests/Models/ReadonlyProperties/Book.php
new file mode 100644
index 00000000000..31e1b5b6be6
--- /dev/null
+++ b/tests/Doctrine/Tests/Models/ReadonlyProperties/Book.php
@@ -0,0 +1,51 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Doctrine\Tests\Models\ReadonlyProperties;
+
+use Doctrine\Common\Collections\ArrayCollection;
+use Doctrine\Common\Collections\Collection;
+use Doctrine\ORM\Mapping\Column;
+use Doctrine\ORM\Mapping\Entity;
+use Doctrine\ORM\Mapping\GeneratedValue;
+use Doctrine\ORM\Mapping\Id;
+use Doctrine\ORM\Mapping\JoinTable;
+use Doctrine\ORM\Mapping\ManyToMany;
+use Doctrine\ORM\Mapping\Table;
+
+#[Entity, Table(name: 'book')]
+class Book
+{
+    #[Column, Id, GeneratedValue]
+    private readonly int $id;
+
+    #[Column]
+    private readonly string $title;
+
+    #[ManyToMany(targetEntity: Author::class), JoinTable(name: 'book_author')]
+    private readonly Collection $authors;
+
+    public function __construct()
+    {
+        $this->authors = new ArrayCollection();
+    }
+
+    public function getId(): int
+    {
+        return $this->id;
+    }
+
+    public function getTitle(): string
+    {
+        return $this->title;
+    }
+
+    /**
+     * @return list<Author>
+     */
+    public function getAuthors(): array
+    {
+        return $this->authors->getValues();
+    }
+}
diff --git a/tests/Doctrine/Tests/Models/ReadonlyProperties/SimpleBook.php b/tests/Doctrine/Tests/Models/ReadonlyProperties/SimpleBook.php
new file mode 100644
index 00000000000..d978d045839
--- /dev/null
+++ b/tests/Doctrine/Tests/Models/ReadonlyProperties/SimpleBook.php
@@ -0,0 +1,41 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Doctrine\Tests\Models\ReadonlyProperties;
+
+use Doctrine\ORM\Mapping\Column;
+use Doctrine\ORM\Mapping\Entity;
+use Doctrine\ORM\Mapping\GeneratedValue;
+use Doctrine\ORM\Mapping\Id;
+use Doctrine\ORM\Mapping\JoinColumn;
+use Doctrine\ORM\Mapping\ManyToOne;
+use Doctrine\ORM\Mapping\Table;
+
+#[Entity, Table(name: 'simple_book')]
+class SimpleBook
+{
+    #[Column, Id, GeneratedValue]
+    private readonly int $id;
+
+    #[Column]
+    private readonly string $title;
+
+    #[ManyToOne, JoinColumn(nullable: false)]
+    private readonly Author $author;
+
+    public function getId(): int
+    {
+        return $this->id;
+    }
+
+    public function getTitle(): string
+    {
+        return $this->title;
+    }
+
+    public function getAuthor(): Author
+    {
+        return $this->author;
+    }
+}
diff --git a/tests/Doctrine/Tests/ORM/Functional/ReadonlyPropertiesTest.php b/tests/Doctrine/Tests/ORM/Functional/ReadonlyPropertiesTest.php
new file mode 100644
index 00000000000..17aa2306df6
--- /dev/null
+++ b/tests/Doctrine/Tests/ORM/Functional/ReadonlyPropertiesTest.php
@@ -0,0 +1,111 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Doctrine\Tests\ORM\Functional;
+
+use Doctrine\ORM\Mapping\Driver\AttributeDriver;
+use Doctrine\ORM\Tools\SchemaTool;
+use Doctrine\Tests\Models\ReadonlyProperties\Author;
+use Doctrine\Tests\Models\ReadonlyProperties\Book;
+use Doctrine\Tests\Models\ReadonlyProperties\SimpleBook;
+use Doctrine\Tests\OrmFunctionalTestCase;
+use Doctrine\Tests\TestUtil;
+
+use function dirname;
+
+/**
+ * @requires PHP 8.1
+ */
+class ReadonlyPropertiesTest extends OrmFunctionalTestCase
+{
+    protected function setUp(): void
+    {
+        if (! isset(static::$sharedConn)) {
+            static::$sharedConn = TestUtil::getConnection();
+        }
+
+        $this->_em         = $this->getEntityManager(null, new AttributeDriver(
+            [dirname(__DIR__, 2) . '/Models/ReadonlyProperties']
+        ));
+        $this->_schemaTool = new SchemaTool($this->_em);
+
+        parent::setUp();
+
+        $this->setUpEntitySchema([Author::class, Book::class, SimpleBook::class]);
+    }
+
+    public function testSimpleEntity(): void
+    {
+        $connection = $this->_em->getConnection();
+
+        $connection->insert('author', ['name' => 'Jane Austen']);
+        $authorId = $connection->lastInsertId();
+
+        $author = $this->_em->find(Author::class, $authorId);
+
+        self::assertSame('Jane Austen', $author->getName());
+        self::assertEquals($authorId, $author->getId());
+    }
+
+    public function testEntityWithLazyManyToOne(): void
+    {
+        $connection = $this->_em->getConnection();
+
+        $connection->insert('author', ['name' => 'Jane Austen']);
+        $authorId = $connection->lastInsertId();
+
+        $connection->insert('simple_book', ['title' => 'Pride and Prejudice', 'author_id' => $authorId]);
+        $bookId = $connection->lastInsertId();
+
+        $book = $this->_em->find(SimpleBook::class, $bookId);
+
+        self::assertSame('Pride and Prejudice', $book->getTitle());
+        self::assertEquals($bookId, $book->getId());
+        self::assertSame('Jane Austen', $book->getAuthor()->getName());
+    }
+
+    public function testEntityWithEagerManyToOne(): void
+    {
+        $connection = $this->_em->getConnection();
+
+        $connection->insert('author', ['name' => 'Jane Austen']);
+        $authorId = $connection->lastInsertId();
+
+        $connection->insert('simple_book', ['title' => 'Pride and Prejudice', 'author_id' => $authorId]);
+        $bookId = $connection->lastInsertId();
+
+        [$book] = $this->_em->createQueryBuilder()
+            ->from(SimpleBook::class, 'b')
+            ->join('b.author', 'a')
+            ->select(['b', 'a'])
+            ->where('b.id = :id')
+            ->setParameter('id', $bookId)
+            ->getQuery()
+            ->execute();
+
+        self::assertInstanceOf(SimpleBook::class, $book);
+        self::assertSame('Pride and Prejudice', $book->getTitle());
+        self::assertEquals($bookId, $book->getId());
+        self::assertSame('Jane Austen', $book->getAuthor()->getName());
+    }
+
+    public function testEntityWithManyToMany(): void
+    {
+        $connection = $this->_em->getConnection();
+
+        $connection->insert('author', ['name' => 'Jane Austen']);
+        $authorId = $connection->lastInsertId();
+
+        $connection->insert('book', ['title' => 'Pride and Prejudice']);
+        $bookId = $connection->lastInsertId();
+
+        $connection->insert('book_author', ['book_id' => $bookId, 'author_id' => $authorId]);
+
+        $book = $this->_em->find(Book::class, $bookId);
+
+        self::assertSame('Pride and Prejudice', $book->getTitle());
+        self::assertEquals($bookId, $book->getId());
+        self::assertSame('Jane Austen', $book->getAuthors()[0]->getName());
+    }
+}