Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hard-coded static env name #5

Open
1000i100 opened this issue Jul 1, 2013 · 5 comments
Open

hard-coded static env name #5

1000i100 opened this issue Jul 1, 2013 · 5 comments
Labels
enhancement Improvement or suggestion

Comments

@1000i100
Copy link

1000i100 commented Jul 1, 2013

line 80 in your src plugin code there is :

Static

if 'static' in docpad.getEnvironments()

the static features could also be triggered by a custom parameters to not enforce static env name use. It could improve compatibility with other plugin using env specific rules.

@balupton
Copy link
Member

balupton commented Jul 1, 2013

Nice suggestion 👍 Any thoughts on what a possible implementation could look like?

@1000i100
Copy link
Author

1000i100 commented Jul 1, 2013

i'm not enough familiar with docpad internals to know how to add custom parameters in config files or command line. Perhaps some time later, right now, i'm just discovering and testing docpad ecosystem.

@balupton
Copy link
Member

balupton commented Jul 1, 2013

Cool, no worries.

@RobLoach
Copy link
Contributor

RobLoach commented Feb 7, 2014

#14 ?

@balupton
Copy link
Member

Fixed in v2.7.0. Note that I've made some changes, see the readme.

@mikeumus mikeumus added the enhancement Improvement or suggestion label Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement or suggestion
Projects
None yet
Development

No branches or pull requests

4 participants