Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK/JRE 18 support #258

Closed
qeepcologne opened this issue Apr 21, 2022 · 7 comments
Closed

JDK/JRE 18 support #258

qeepcologne opened this issue Apr 21, 2022 · 7 comments

Comments

@qeepcologne
Copy link

qeepcologne commented Apr 21, 2022

java18 released 4 weeks ago

@sujiansoft

This comment was marked as spam.

@alfonx

This comment was marked as spam.

@cybercooll

This comment was marked as spam.

@bfySebman

This comment was marked as spam.

@qeepcologne
Copy link
Author

qeepcologne commented Jul 7, 2022

i justed forked it into my multi-layer-dockerfile and changed the from section without difficulties:

FROM eclipse-temurin:18-jre-jammy as tomcat_10.0.22-jre18-temurin
ENV CATALINA_HOME /usr/local/tomcat
ENV PATH $CATALINA_HOME/bin:$PATH
RUN mkdir -p "$CATALINA_HOME"
WORKDIR $CATALINA_HOME
# let "Tomcat Native" live somewhere isolated
ENV TOMCAT_NATIVE_LIBDIR $CATALINA_HOME/native-jni-lib
ENV LD_LIBRARY_PATH ${LD_LIBRARY_PATH:+$LD_LIBRARY_PATH:}$TOMCAT_NATIVE_LIBDIR
# see https://www.apache.org/dist/tomcat/tomcat-10/KEYS
# see also "versions.sh" (https://github.com/docker-library/tomcat/blob/master/versions.sh)
ENV GPG_KEYS A9C5DF4D22E99998D9875A5110C01C5A2F6059E7
ENV TOMCAT_MAJOR 10
ENV TOMCAT_VERSION 10.0.22
ENV TOMCAT_SHA512 fe46db8794f066882b30e7a94bd8d3dbcf29e8e8ffaf67c1355846755745a7c9eafd124819283f218bcf410921a485b44b57b56fd6251fb99d67d95f3dd36826
COPY --from=tomcat:10.0.22-jdk17-temurin-jammy $CATALINA_HOME $CATALINA_HOME
RUN set -eux; \
	apt-get update; \
	xargs -rt apt-get install -y --no-install-recommends < "$TOMCAT_NATIVE_LIBDIR/.dependencies.txt"; \
	rm -rf /var/lib/apt/lists/*
# verify Tomcat Native is working properly
RUN set -eux; \
	nativeLines="$(catalina.sh configtest 2>&1)"; \
	nativeLines="$(echo "$nativeLines" | grep 'Apache Tomcat Native')"; \
	nativeLines="$(echo "$nativeLines" | sort -u)"; \
	if ! echo "$nativeLines" | grep -E 'INFO: Loaded( APR based)? Apache Tomcat Native library' >&2; then \
		echo >&2 "$nativeLines"; \
		exit 1; \
	fi
EXPOSE 8080
CMD ["catalina.sh", "run"]

@tianon
Copy link
Member

tianon commented Nov 29, 2022

Linking to the very relevant #248 (comment) (sorry for not typing this up sooner 🙇).

See also #275 (comment)

@wglambert wglambert mentioned this issue Feb 21, 2023
@tianon
Copy link
Member

tianon commented May 8, 2023

Thanks for the push (and for the implementation suggestions!! 🙇 ❤️); I'm going to close this now in order to consolidate into #299 😅

@tianon tianon closed this as completed May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants