Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scaling issues in deploy #22

Closed
tianon opened this issue Feb 7, 2024 · 0 comments · Fixed by #38
Closed

scaling issues in deploy #22

tianon opened this issue Feb 7, 2024 · 0 comments · Fixed by #38
Assignees

Comments

@tianon
Copy link
Member

tianon commented Feb 7, 2024

With #5 and #16, our builds.json and sources.json generators are now really fast (and respectful of our upstream registry rate limits), but we're still very slow at deploying images (to the point that deploying often fails before it gets through the full set 😭). The deploy job is currently effectively "generate a bunch of crane cp commands and run them", which isn't terribly efficient:

meta-scripts/jenkins.jq

Lines 13 to 17 in 80bb556

| if length == 1 then
@sh "crane copy \(.) \($target)"
else
@sh "crane index append --tag \($target) " + (map("--manifest " + @sh) | join(" ")) + " --flatten"
end

I'm working on a new version of this that is more native to our process so that things like auth tokens can be shared between API invocations more correctly/effectively, but wanted to file an issue to track the problem (especially because it's now the main blocker to our scaling up much more).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant