-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timing attack #31
Comments
Seems legit, implemented and pushed out 👍 |
Out of curiosity: where'd you find the |
Your code is vulnerable to a timing attack because you use a basic string comparison. You should use
hash_equals
or, if you need/want to support older versions than 5.6, a simple loop that iterates the entire string, regardless of the result like this (disclaimer: author here).Both your references have either addressed the issue or still have an active issue:
The text was updated successfully, but these errors were encountered: