Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue Warnings for DLL's that Don't Include a Version #14

Open
WillStrohl opened this issue Sep 5, 2018 · 0 comments
Open

Issue Warnings for DLL's that Don't Include a Version #14

WillStrohl opened this issue Sep 5, 2018 · 0 comments

Comments

@WillStrohl
Copy link
Contributor

In the manifest, you're able to specify DLL's that should be installed with an extension. This tells the installer what they are, and that they should be found in the installation package.

It's currently optional to include a version number for the DLL, which is okay since it introduces flexibility for multiple use cases. An example of both scenarios is below.

<component type="Assembly">
  <assemblies>
	<assembly>
	  <path>bin</path>
	  <name>EntityFramework.dll</name>
	  <sourceFileName>bin\EntityFramework.dll</sourceFileName>
	</assembly>
	<assembly>
	  <path>bin</path>
	  <name>ImageResizer.dll</name>
	  <sourceFileName>bin\ImageResizer.dll</sourceFileName>
	  <version>4.0.0</version>
	</assembly>
  </assemblies>
</component>

The EVS scan should create a warning message for each DLL that does not include a version number. It's not an error message, but it's definitely something for a website owner to be aware of before installing an extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant