Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP / Do Not Merge] Create MusicXMLDecoder #181

Closed
wants to merge 4 commits into from
Closed

Conversation

jsbean
Copy link
Member

@jsbean jsbean commented Oct 17, 2019

Resolves #179.

@codecov-io
Copy link

codecov-io commented Oct 17, 2019

Codecov Report

Merging #181 into latest will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #181      +/-   ##
==========================================
+ Coverage   69.69%   69.72%   +0.03%     
==========================================
  Files         222      223       +1     
  Lines        3557     3561       +4     
==========================================
+ Hits         2479     2483       +4     
  Misses       1078     1078
Impacted Files Coverage Δ
Sources/MusicXML/Decoding/MusicXMLDecoder.swift 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eea1c9...6853b97. Read the comment docs.

@jsbean jsbean changed the title Create MusicXMLDecoder [WIP / Do Not Merge] Create MusicXMLDecoder Oct 17, 2019
@jsbean
Copy link
Member Author

jsbean commented Oct 18, 2019

@DJBen, I updated all usages of XMLDecoder to MusicXMLDecoder.

Setting trimValueWhitespaces to false solves the single case of the copyright symbol, though breaks many other tests.

It seems like this should really be solved upstream?

@jsbean
Copy link
Member Author

jsbean commented Nov 22, 2019

We can give this a shot down the line once we feel good about the encoding process!

@jsbean jsbean closed this Nov 22, 2019
@jsbean jsbean deleted the musicxmldecoder branch February 24, 2020 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a MusicXMLDecoder: XMLDecoder subclass
2 participants