Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more MusicXML samples to test suite #149

Open
jsbean opened this issue Oct 13, 2019 · 2 comments
Open

Add more MusicXML samples to test suite #149

jsbean opened this issue Oct 13, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@jsbean
Copy link
Member

jsbean commented Oct 13, 2019

The LilyPond test suite has relatively good coverage, but some real-world examples will be nice. For example, Beethoven string quartets.

This will also raise the stakes w/r/t performance.

@jsbean jsbean added the enhancement New feature or request label Oct 13, 2019
@jsbean jsbean added this to the 0.3.0 milestone Oct 13, 2019
@jsbean jsbean added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 13, 2019
@DJBen
Copy link
Collaborator

DJBen commented Oct 14, 2019

I am working on it to establish a general test suite that test against score parsing.

IMO there are a few examples from the Music XML website worth testing.

Starting from this excerpt from https://www.musicxml.com/tutorial/notation-basics/looks-vs-sounds/, and followed by the example set, we can test this against a dozen real scores.

What do you think of introducing these to score testing? Looking forward to your opinion.

@jsbean
Copy link
Member Author

jsbean commented Oct 14, 2019

In fact, I was poking around those myself. I think those are a great place to start.

I think a PR just introducing those tests, along with a slightly-more generalized testing API (i.e., right now we are looking only for LilyPond, but it could be from anywhere) would be amazing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants