Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support np arrays for Vertical Federated Learning #9360

Closed
edumugi opened this issue Jul 5, 2023 · 3 comments
Closed

Support np arrays for Vertical Federated Learning #9360

edumugi opened this issue Jul 5, 2023 · 3 comments

Comments

@edumugi
Copy link
Contributor

edumugi commented Jul 5, 2023

Experimenting with the federated plugin (#8424) in a vertical environment I noticed that giving data as a numpy array to the DMatrix is not supported yet.

It should be a really easy fix since we only need to support the data_split_mode arg in the _from_numpy_array function.

Steps would be:

  • Add new arg data_split_mode to _from_numpy_array in file python-package/xgboost/data.py
  • Read data_split_mode from config in function XGDMatrixCreateFromDense inside file src/c_api/c_api.cc

Should I open a PR for these changes?

@trivialfis
Copy link
Member

The federated learning support is still working in progress. cc @rongou .

@rongou
Copy link
Contributor

rongou commented Jul 5, 2023

Yes, feel free to send @trivialfis and me a PR.

@trivialfis
Copy link
Member

Thank you for the feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants