-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Use rapids-dependency-file-generator
to generate pyproject.toml
#10803
Comments
How about re-naming of the package? ( |
Thanks for the To replace the patch, before involving xgboost/python-package/packager/pep517.py Lines 45 to 47 in f52f11e
With a bit of Python code that optionally adds the appropriate That's similar to what
I think this should be avoided for as long as possible. There is significant usage of the name Before making any decision, I recommend reading through these discussions:
I am still working through them myself... but there are a lot of ideas about these topics in there. I hope that was helpful, sorry that it's a lot 😅 . |
@jameslamb Can you look at my proposal at #10807? I tried to make it as least disruptive as possible. |
I agree.
Looks like a great idea. Thank you for the detailed explanation. I will look into this as well. Going through the discussion, I think we can wait a little bit and see what PyPI will do. For now, conda-forge might be a better place to provide build variants. |
Currently, we use a patch to remove
nvidia-nccl-cu12
from the dependencies when building the CPU wheel:xgboost/tests/buildkite/remove_nccl_dep.patch
Lines 1 to 12 in f52f11e
This approach has several disadvantages:
Proposal. Use
rapids-dependency-file-generator
to modify thedependencies
section inpyproject.toml
.The tool is standalone and lightweight, and can be easily integrated in our CI/CD pipelines.
The following configuration will let us generate three variants (CPU, CUDA 11, CUDA 12):
Command:
rapids-dependency-file-generator --file-key pyproject --output pyproject --matrix cuda=12.4
cc @jameslamb
The text was updated successfully, but these errors were encountered: