Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catboost support #83

Closed
rspadim opened this issue Mar 7, 2019 · 9 comments
Closed

Catboost support #83

rspadim opened this issue Mar 7, 2019 · 9 comments

Comments

@rspadim
Copy link

rspadim commented Mar 7, 2019

No description provided.

@hcho3
Copy link
Collaborator

hcho3 commented Mar 12, 2019

@rspadim Are you familiar with how Catboot saves models?

@rspadim
Copy link
Author

rspadim commented Mar 12, 2019

there're some types, and very interesting since some are wellknown formats (standards)
i will point it here, and try to upload some samples
https://github.com/catboost/catboost/blob/master/catboost/libs/model/model.cpp#L174

@hcho3
Copy link
Collaborator

hcho3 commented Mar 12, 2019

@rspadim It may be still beneficial to add Catboost support in Treelite, if you'd like to generate pure C code without external dependency. That said, closing for now.

@hcho3 hcho3 closed this as completed Mar 12, 2019
@rspadim
Copy link
Author

rspadim commented Mar 12, 2019

an exampel to create models:

from sklearn.datasets import load_boston
X, y = load_boston(return_X_y=True)
print('dimensions of X = {}'.format(X.shape))
print('dimensions of y = {}'.format(y.shape))

from catboost import CatBoost
model = CatBoost()
model.fit(X, y)
for i in ['cpp', 'python', 'json', 'cbm', 'onnx', 'coreml']:
    print(i)
    model.save_model(fname="teste.catboost." + i, format=i)
print("hello")

@rspadim
Copy link
Author

rspadim commented Mar 12, 2019

hi @hcho3 , yes i agree with you, pure C is the best think treelite have, it's very intuitive to port to any language

@hcho3 hcho3 reopened this Mar 12, 2019
@hcho3 hcho3 changed the title could be possible include catboost? Catboost support Mar 12, 2019
@hcho3
Copy link
Collaborator

hcho3 commented Mar 12, 2019

@rspadim It is the job of Treelite contributors to support Catboost, not Catboost contributors. I think you should close catboost/catboost#721.

Also re-opening this issue, as a reminder that we should support Catboost

@hcho3
Copy link
Collaborator

hcho3 commented Apr 19, 2022

Closing in favor of #377

@hcho3 hcho3 closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants