Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Difference in naming convention between op.py and test_op.py #1580

Open
AetherPrior opened this issue Aug 24, 2021 · 0 comments
Open

Difference in naming convention between op.py and test_op.py #1580

AetherPrior opened this issue Aug 24, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@AetherPrior
Copy link
Contributor

Description

Mxnet's NumPy is being imported as np in the file src/gluonnlp/op.py:

from mxnet import np, npx

While NumPy is imported as np in test_op.py:

import numpy as np

This requires a change in conventions between tests and code, which can be a minor nuisance.

What have you tried to solve it?

  1. While a simple refactoring is possible, I don't want to be reverting any design decision in any way.
@AetherPrior AetherPrior added the bug Something isn't working label Aug 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant