Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated CMake function test_big_endian used #688

Open
jakirkham opened this issue Jul 27, 2024 · 0 comments
Open

Deprecated CMake function test_big_endian used #688

jakirkham opened this issue Jul 27, 2024 · 0 comments

Comments

@jakirkham
Copy link

Currently the CMakeLists.txt here makes use of test_big_endian:

dmlc-core/CMakeLists.txt

Lines 166 to 173 in 1334185

# Check endianness
include(TestBigEndian)
test_big_endian(BIG_ENDIAN)
if(BIG_ENDIAN)
set(DMLC_CMAKE_LITTLE_ENDIAN 0)
else()
set(DMLC_CMAKE_LITTLE_ENDIAN 1)
endif()


However according to the CMake documentation, this is deprecated:

Deprecated since version 3.20: Supserseded by the CMAKE_<LANG>_BYTE_ORDER variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant