-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Logging level support #623
Comments
@trivialfis This is a good time to port dmlc/xgboost#3982 to dmlc-core. I'd like to give it a try. |
Not sure about that. I have a similar logging utility for my own use with some additional features like signal handling (printing a backtrace when segfault). But the more I use logging, the more I like about Python's |
I agree that Python
Do you see a clear design flaw in dmlc/xgboost#3982? |
Not yet, maybe no support for user defined verbosity level?
Yup, I meant we can implement something similar to python
Sure, that won't be a problem. But since dmlc-core is a common brick for other libraries. Giving it some more thought would be great. |
Since dmlc-core logging is providing logging capability to several projects, it would be great to have the capability of setting logging levels which will improve the user experience in these projects.
apache/mxnet#16666
apache/mxnet#10492
The implementation should allow changing the logging level at runtime, and for disabled logging levels, the invocation should incur as little overhead as possible.
The text was updated successfully, but these errors were encountered: