-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HeteroGraphConv's forward need to modify #7685
Comments
Thanks for filing the issue. Is there a reason for not defining separate edge types (e.g. edge1 and edge2) when the source nodes are of different types in this example? Are there any special considerations to keep in mind? |
Yes, I know there are ways to avoid this problem, but I think as a framework itself, there should be no assumptions about the user's source data schema. @rudongyu |
Thanks for further elaboration. I see your point. We’ve added it to our backlog to get prioritized over other feature requests in our roadmap. You are also appreciated to contribute to DGL to get it supported, thanks! |
🚀 Feature
*mod_args.get(etype,()) and **mod_kwargs.get(etype,{}) in HeteroGraphConv's forward need to be changed to *mod_args.get((stype, etype, dtype),()) and **mod_kwargs.get((stype, etype, dtype),{})
Motivation
For heterogeneous graphs, the parameters of a homogeneous graph cannot be determined only by etype, for example, if there are two kinds of edges (node1,edge1,node1) and (node2,edge1,node1).
The text was updated successfully, but these errors were encountered: