Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There's no way to set allowed: false on Dai permits #12

Open
lukehutch opened this issue May 17, 2022 · 0 comments
Open

There's no way to set allowed: false on Dai permits #12

lukehutch opened this issue May 17, 2022 · 0 comments

Comments

@lukehutch
Copy link

Dai permits are hard-coded to allow: true. Consequently there is no way to set the allowance back to zero using the permitting API, once permitting should be disallowed.

https://github.com/dmihal/eth-permit/blob/master/src/eth-permit.ts#L116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lukehutch