Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build.commonjsOptions.ignore from vite.config.ts #121

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

Peeterush
Copy link
Contributor

Digging into #119 I found that Vite has changed the way it handles the dependencies in question from version 4 and up for both building and consuming.

  • For consuming: in version 4 and up you seem to need ws in your own project to be able to build when using this library. Maybe version 3 supplied projects with the ws that Vite uses itself?
  • For building: Vite will now automatically externalize the build in modules, and also seems to have a solution for ws.

Taking advantage of these changes by removing build.commonjsOptions.ignore seems to resolve both #119 and also remove the need to install ws in consuming projects.

@dlemstra dlemstra merged commit 4086e75 into dlemstra:main Oct 30, 2023
10 checks passed
@Peeterush Peeterush deleted the remove-ignore branch November 4, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants