Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presentation-specific behaviors appear in POST manifest response #180

Open
griffri opened this issue Nov 21, 2024 · 2 comments
Open

Presentation-specific behaviors appear in POST manifest response #180

griffri opened this issue Nov 21, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@griffri
Copy link
Contributor

griffri commented Nov 21, 2024

When you POST a new manifest to /manifests, the returned JSON will show a behavior field containing what was defined in the payload, like so:

  ...
  "modified": "2024-11-21T15:30:20Z",
  "createdBy": "Admin",
  "@context": [
    "http://tbc.org/iiif-repository/1/context.json",
    "http://iiif.io/api/presentation/3/context.json"
  ],
  "id": "https://presentation-api.dlcs.digirati.io/52/manifests/74nrg5qi9h4h3fqla2rq",
  "type": "Manifest",
  "label": {"en":["Example Manifest"]},
  "behavior": [
    "public-iiif",
    "paged"
  ],
  ...

But if you request GET on the same manifest's flat URL afterwards, any behaviour specific to Presentation (e.g public-iiif) will be omitted:

  ...
  "modified": "2024-11-21T15:30:20Z",
  "createdBy": "Admin",
  "@context": [
    "http://tbc.org/iiif-repository/1/context.json",
    "http://iiif.io/api/presentation/3/context.json"
  ],
  "id": "https://presentation-api.dlcs.digirati.io/52/manifests/74nrg5qi9h4h3fqla2rq",
  "type": "Manifest",
  "label": {
    "en": [
      "Example Manifest"
    ]
  },
  "behavior": [
    "paged"
  ],
  ...
@griffri griffri added the bug Something isn't working label Nov 21, 2024
@donaldgray
Copy link
Member

Not a bug - Manifests shouldn't have these behaviours.

@donaldgray
Copy link
Member

Reopened - the bug is that the custom items are returned in POST body, rather than them being missing from GET.

I will fix alongside #62

@donaldgray donaldgray self-assigned this Nov 21, 2024
@griffri griffri changed the title Presentation-specific behaviors do not appear in manifest flat GET Presentation-specific behaviors appear in POST manifest response Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants