Fix Bugzilla 24872 - Assigning non-copyable value to array has no effect

dlang · Nov 22, 2024 · e13c618 · e13c618
1 parent 3fa3ac8
commit e13c618
Showing 1 changed file with 15 additions and 1 deletion.
diff --git a/druntime/src/core/internal/array/arrayassign.d b/druntime/src/core/internal/array/arrayassign.d
@@ -347,7 +347,7 @@ Tarr _d_arraysetassign(Tarr : T[], T)(return scope Tarr to, scope ref T value) @
         static if (__traits(isCopyable, T))
             copyEmplace(value, dst);
         else
-            memcpy(cast(void*) &value, cast(void*) &dst, elemSize);
+            memcpy(cast(void*) &dst, cast(void*) &value, elemSize);
         auto elem = cast(Unqual!T*) &tmp;
         destroy(*elem);
     }
@@ -395,6 +395,20 @@ Tarr _d_arraysetassign(Tarr : T[], T)(return scope Tarr to, scope ref T value) @
     assert(arr == [S(1234), S(1234), S(1234), S(1234)]);
 }
 
+// disabled copy constructor
+@safe unittest
+{
+    static struct S
+    {
+        int val;
+        @disable this(ref S);
+    }
+    S[1] arr;
+    S s = S(1234);
+    _d_arraysetassign(arr[], s);
+    assert(arr[0].val == 1234);
+}
+
 // throwing and `nothrow`
 @safe nothrow unittest
 {