Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository names with dots are not redirected #12

Open
oxc opened this issue Sep 28, 2015 · 1 comment
Open

Repository names with dots are not redirected #12

oxc opened this issue Sep 28, 2015 · 1 comment
Labels
Milestone

Comments

@oxc
Copy link
Contributor

oxc commented Sep 28, 2015

Since the @RequestMapping does not match periods by default, repository names containing one are not matched fully, resulting in incorrect redirect.

E.g http://glproxy/namespace/repo.name is redirected to http://gitlab/namespace/repo

If I'm not mistaken, this can be fixed by adding a custom pattern to the path variable (/{repo:.*})

@oxc
Copy link
Contributor Author

oxc commented Sep 29, 2015

Please note that gitlab has its own issues with periods in project names (gitlabhq/gitlabhq#8553), please keep that in mind when testing.
I've hacked my own workaround into java-gitlab-api in order to get the project show up in the first place.

@dka23 dka23 added the bug label Sep 29, 2015
@dka23 dka23 added this to the 1.0.0 milestone Sep 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants