-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Puppetlabs/firewall module dependency #168
Comments
Hi there. I must admit, this wasn't on our radar but I think it's a good idea. If you could submit a PR for this that would be great, thanks. |
Hi Jonathan, do you want the PR against the main branch or the 3.9.2 tag? |
Against main, please. Should be nice and easy to merge 🙂 |
#170 ready for review 8-) |
Thanks Jonathan. Once we are running with a higher version of puppetlabs firewall module and can test, I'll create another PR |
Thanks @deligatedgeek, that's great. I've also restarted discussed with my collaborators about doing another release, because I've just realised it's been over 2 years now! There's a lot of improvements that have never been tagged in a release. Feel free to weigh in on #156 if you have any strong feelings about that 😄 |
Excellent, will check #156 out. |
Currently this module has a dependency on an old version of Puppetlabs/firewall, are there any plans to update this dependency?
I am happy submit a PR for a newer version
The text was updated successfully, but these errors were encountered: