Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppetlabs/firewall module dependency #168

Closed
deligatedgeek opened this issue Nov 22, 2021 · 7 comments
Closed

Puppetlabs/firewall module dependency #168

deligatedgeek opened this issue Nov 22, 2021 · 7 comments

Comments

@deligatedgeek
Copy link
Contributor

Currently this module has a dependency on an old version of Puppetlabs/firewall, are there any plans to update this dependency?

I am happy submit a PR for a newer version

@djjudas21
Copy link
Owner

Hi there. I must admit, this wasn't on our radar but I think it's a good idea. If you could submit a PR for this that would be great, thanks.

@deligatedgeek
Copy link
Contributor Author

Hi Jonathan, do you want the PR against the main branch or the 3.9.2 tag?

@djjudas21
Copy link
Owner

Against main, please. Should be nice and easy to merge 🙂

@deligatedgeek
Copy link
Contributor Author

#170 ready for review 8-)

@deligatedgeek
Copy link
Contributor Author

Thanks Jonathan. Once we are running with a higher version of puppetlabs firewall module and can test, I'll create another PR

@djjudas21
Copy link
Owner

Thanks @deligatedgeek, that's great. I've also restarted discussed with my collaborators about doing another release, because I've just realised it's been over 2 years now! There's a lot of improvements that have never been tagged in a release. Feel free to weigh in on #156 if you have any strong feelings about that 😄

@deligatedgeek
Copy link
Contributor Author

Excellent, will check #156 out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants