Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS: UFS wrapper could likely be reduced #33

Open
djdv opened this issue Jun 29, 2023 · 0 comments
Open

IPFS: UFS wrapper could likely be reduced #33

djdv opened this issue Jun 29, 2023 · 0 comments

Comments

@djdv
Copy link
Owner

djdv commented Jun 29, 2023

Extracted from: #27 (comment)

The files.File we embed here, is derived from unixfsfile.NewUnixfsFile which takes in a context already, and has simillar semantics internally (it cancels on Close).

Our wrapper could probably be reduced to remove some redundancy, instead just relying on the embedded methods and behaviour being hoisted up.

This might be true for other types too. But requires peeking into the implementations they wrap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant