-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve makefile and docs to simplify project setup without docker #42
Comments
hello @DevilsAutumn can you assign me on this? |
Done @SureshPradhana , thanks for picking up this. |
@DevilsAutumn Does this need to connect to and run all backend services similar to Docker? |
yeah, kind of. |
should i use docker containers for postgres and rabbitmq inside makefile |
No, terminal commands should be used. Also no need to use postgres for if we're running without docker. |
Should the Makefile be written assuming that postgres and rabbitmq are already manually set up? |
we are using sqlite instead of postgres for setup without docker. I dont think it would require some kind of check before starting the application(not sure). |
I will change the Makefile to only run the backend; RabbitMQ and other services will need to be run manually. |
can do something like this # RabbitMQ commands
check-rabbitmq:
@if ! sudo service rabbitmq-server status | grep -q "active (running)"; then \
echo "RabbitMQ is not installed or not running. Please install and start RabbitMQ service."; \
exit 1; \
fi
start-rabbitmq:
sudo service rabbitmq-server start
stop-rabbitmq:
sudo service rabbitmq-server stop |
Can we run the start-rabbitmq command under run backend command in makefile itself? |
Yes, but it may throw error for everyone who run |
ok lets keep them independent for now. |
@DevilsAutumn If we don't use Docker and instead rely only on a Makefile, we have to manage it based on different OSes, each of which has different ways of starting RabbitMQ. I think it's better to start services manually or use Docker, as using a Makefile will require managing differences across various OSes. |
hmm makes sense. Probably we should change this issue to improve the docs related to setting up the project on local for different OSes, along with some additional commands for frontend in makefile. What do you think? |
improving the docs would be very beneficial, and I believe the Makefile should only be used to run the frontend and backend. |
Perfect. Thankyou. |
Makefile has some commands as of now but it can improved to prevent running multiple commands to setup and run project project locally. Improvements should be done such that one or two command should be able to install all deps, build both frontend backend, and run both frontend and backend without docker. Something like
make frontend
andmake backend
would work.The text was updated successfully, but these errors were encountered: