Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build up history for new benchmarks #47

Open
smithdc1 opened this issue Jun 22, 2022 · 3 comments
Open

Build up history for new benchmarks #47

smithdc1 opened this issue Jun 22, 2022 · 3 comments

Comments

@smithdc1
Copy link
Member

Hi @deepakdinesh1123

https://smithdc1.github.io/django-asv/ the website looks great with new results being added yesterday.

One thought is that when we're adding new benchmarks can we build up some history by running against the list of commits that you had? The aim being to build up a trend line?

image

What do you think?

@smithdc1 smithdc1 changed the title Build up history for new benchmars Build up history for new benchmarks Jun 22, 2022
@deepakdinesh1123
Copy link
Contributor

Hi @smithdc1

Should I also add the history for python versions 3.8 and 3.9 for all the benchmarks? If yes, I think it might be better to add them as a separate PR.

@smithdc1
Copy link
Member Author

That sounds good, if possible.

Separate prs sounds good too.

We will need to think about maintainability going forward. That is, how do we add and remove python versions. Does it "just work" (tm) or is there something that will cause issues?

@deepakdinesh1123
Copy link
Contributor

Since miniconda is being used by ASV adding or removing python versions does not cause any problems, but adding versions of python that are not supported by the version of Django being benchmarked causes the benchmarks to fail but this won't be a problem since --strict option is not used when building results history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants