Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMPROVEMENT: Inconsistency in Code #211

Open
agy-why opened this issue Aug 30, 2023 · 0 comments
Open

IMPROVEMENT: Inconsistency in Code #211

agy-why opened this issue Aug 30, 2023 · 0 comments

Comments

@agy-why
Copy link
Member

agy-why commented Aug 30, 2023

In https://github.com/django-daiquiri/daiquiri/blob/master/daiquiri/oai/adapter.py#L206

There is an inconsistancy between the naming of the classes:

  • DatalinkOAIAdapterMixin (correct?)

vs

  • BaseOaiAdapter
  • MetadataOaiAdapterMixin
  • RegistryOaiAdapterMixin
  • DefaultOaiAdapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant