Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method for is_valid to the Aggregator trait #1133

Closed
divergentdave opened this issue Nov 8, 2024 · 3 comments
Closed

Add a method for is_valid to the Aggregator trait #1133

divergentdave opened this issue Nov 8, 2024 · 3 comments

Comments

@divergentdave
Copy link
Contributor

We don't currently capture the is_valid() method defined in the VDAF spec in any traits. This is needed to safely use Poplar1, and Mastic (#1107) will need it as well.

@rozbb
Copy link
Contributor

rozbb commented Nov 12, 2024

Some questions on this:

  1. What precisely is the spec's is_valid() function doing with the list of previous agg params? It appears to only be reading 1 value from the list. Why is it a list?
  2. How are aggregators expected to know the previous aggregation parameters for a given share? A dict of input share => set(Poplar1AggregationParam)?. How long are they supposed to retain this dict?

@divergentdave
Copy link
Contributor Author

The interface is more expressive than strictly needed to allow for flexibility needed by future VDAFs. Mastic has the most interesting aggregation parameter validity conditions thus far: https://jimouris.github.io/draft-mouris-cfrg-mastic/draft-mouris-cfrg-mastic.html#name-validity-of-aggregation-par

This is connected to protections against replay attacks at the DAP level. The main strategy that implementations use to limit data storage needs is to define a time window of report timestamps that they will aggregate, and delete anti-replay data for reports that are old enough that they will no longer be accepted. For VDAFs with nontrivial aggregation parameters, the previously used aggregation parameters will be stored and deleted in the same way.

@divergentdave
Copy link
Contributor Author

Fixed by #1139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants