-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The metrics exposed by dkron are only of summary type and cannot cover related analysis for specific jobs. #1310
Comments
/metrics
does not expose job-related metrics
I still prefer to trace related metrics such as dkron_job_execution_time_seconds and dkron_job_execution_done_count in the dkron server, so that when using prometheus for monitoring, I can configure fewer endpoints and only collect server role nodes. |
It would be best to change the following code: defer metrics.MeasureSince([]string{"grpc", "execution_done"}, time.Now()) to: jobLabel := metrics.Label{Name: "job_name", Value: execDoneReq.Execution.JobName}
defer metrics.MeasureSinceWithLabels([]string{"grpc", "execution_done"}, time.Now(), []metrics.Label{jobLabel}) |
@vcastellm Please reopen it. The current implementation in plugin is not elegant. I will try the way mentioned above. |
Can you work on a follow up PR or should I revert? |
I will follow up. Thanks. |
Is your feature request related to a problem? Please describe.
The metric dkron_grpc_client_agent_run needs to add some necessary labels, such as job_name...
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: