Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the APIAbort exception to defer the abort to _dispatch for consistency #3137

Open
portante opened this issue Dec 23, 2022 · 0 comments
Open

Comments

@portante
Copy link
Member

portante commented Dec 23, 2022

We should really use the APIAbort exception to defer the abort to _dispatch so we're consistent. We still have the user API classes that don't extend ApiBase, unfortunately, but they'll be gone soon. (I fixed PUT, and I'll retain that part of the PR along with the error-case functional tests when I can rebase on top of your NGINX fix.)

So I'll approve this without a lot of excitement; but it is an immediate fix for the namespace mismatch, and we still have the user APIs... and the message example is probably a nice touch.

Originally posted by @dbutenhof in #3130 (review)

@portante portante changed the title We should really use the APIAbort exception to defer the abort to _dispatch so we're consistent. We still have the user API classes that don't extend ApiBase, unfortunately, but they'll be gone soon. (I fixed PUT, and I'll retain that part of the PR along with the error-case functional tests when I can rebase on top of your NGINX fix.) Use the APIAbort exception to defer the abort to _dispatch for consistency Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant